Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: default to using bn254 in noirc_frontend #5144

Merged
merged 1 commit into from
May 30, 2024
Merged

chore: default to using bn254 in noirc_frontend #5144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@
}
}
TraitItem::Type { name } => {
// TODO(nickysn or alexvitkov): implement context.def_interner.push_empty_type_alias and get an id, instead of using TypeAliasId::dummy_id()

Check warning on line 503 in compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (nickysn)

Check warning on line 503 in compiler/noirc_frontend/src/hir/def_collector/dc_mod.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (alexvitkov)
if let Err((first_def, second_def)) = self.def_collector.def_map.modules
[trait_id.0.local_id.0]
.declare_type_alias(name.clone(), TypeAliasId::dummy_id())
Expand Down Expand Up @@ -741,12 +741,10 @@
}

cfg_if::cfg_if! {
if #[cfg(feature = "bn254")] {
pub const CHOSEN_FIELD: &str = "bn254";
} else if #[cfg(feature = "bls12_381")] {
if #[cfg(feature = "bls12_381")] {
pub const CHOSEN_FIELD: &str = "bls12_381";
} else {
compile_error!("please specify a field to compile with");
pub const CHOSEN_FIELD: &str = "bn254";
}
}

Expand Down
Loading