Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement comptime support for array_len builtin #5272

Merged
merged 3 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions compiler/noirc_frontend/src/hir/comptime/interpreter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
use super::errors::{IResult, InterpreterError};
use super::value::Value;

mod builtin;
mod unquote;

#[allow(unused)]
Expand Down Expand Up @@ -99,8 +100,13 @@
.expect("all builtin functions must contain a function attribute which contains the opcode which it links to");

if let Some(builtin) = func_attrs.builtin() {
let item = format!("Evaluation for builtin functions like {builtin}");
Err(InterpreterError::Unimplemented { item, location })
match builtin.as_str() {
"array_len" => builtin::array_len(&arguments),
_ => {
let item = format!("Evaluation for builtin function {builtin}");
Err(InterpreterError::Unimplemented { item, location })
}
}
} else if let Some(foreign) = func_attrs.foreign() {
let item = format!("Evaluation for foreign functions like {foreign}");
Err(InterpreterError::Unimplemented { item, location })
Expand All @@ -113,7 +119,7 @@
}
} else {
let name = self.interner.function_name(&function);
unreachable!("Non-builtin, lowlevel or oracle builtin fn '{name}'")

Check warning on line 122 in compiler/noirc_frontend/src/hir/comptime/interpreter.rs

View workflow job for this annotation

GitHub Actions / Code

Unknown word (lowlevel)
}
}

Expand Down
12 changes: 12 additions & 0 deletions compiler/noirc_frontend/src/hir/comptime/interpreter/builtin.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
use noirc_errors::Location;

use crate::hir::comptime::{errors::IResult, Value};

pub(super) fn array_len(arguments: &[(Value, Location)]) -> IResult<Value> {
assert_eq!(arguments.len(), 1, "ICE: `array_len` should only receive a single argument");
match &arguments[0].0 {
Value::Array(values, _) | Value::Slice(values, _) => Ok(Value::U32(values.len() as u32)),
// Type checking should prevent this branch being taken.
_ => unreachable!("ICE: Cannot query length of types other than arrays or slices"),
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[package]
name = "comptime_array_len"
type = "bin"
authors = [""]

[dependencies]
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
fn main() {
comptime
{
assert_eq([1, 2, 3].len(), 3);
}
}
Loading