Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(perf): Simplify poseidon2 algorithm #5811

Merged
merged 7 commits into from
Aug 27, 2024
Merged

chore(perf): Simplify poseidon2 algorithm #5811

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
afb271c
remove cache loop at the end of squeeze as it adds unnecessary brilli…
vezenovm Aug 23, 2024
e3cc82b
simplify squeeze further
vezenovm Aug 26, 2024
ca68b13
simplify perform_duplex use self.state directly
vezenovm Aug 26, 2024
33d4337
Merge branch 'master' into mv/remove-last-cache-loop-in-poseidon-squeeze
vezenovm Aug 26, 2024
20de992
Merge branch 'master' into mv/remove-last-cache-loop-in-poseidon-squeeze
vezenovm Aug 26, 2024
c79aceb
Merge branch 'master' into mv/remove-last-cache-loop-in-poseidon-squeeze
vezenovm Aug 26, 2024
f64f4af
more brillig code size opts, get rid of branch that is never hit
vezenovm Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions noir_stdlib/src/hash/poseidon2.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,6 @@ impl Poseidon2 {
}
// By this point, we should have a non-empty cache. Pop one item off the top of the cache and return it.
let result = self.cache[0];
for i in 1..RATE {
if i < self.cache_size {
self.cache[i - 1] = self.cache[i];
}
}
self.cache_size -= 1;
self.cache[self.cache_size] = 0;
result
}

Expand Down
Loading