Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Remove unused loads in mem2reg and last stores per function #5925

Merged
merged 67 commits into from
Sep 17, 2024
Merged

feat(perf): Remove unused loads in mem2reg and last stores per function #5925

Changes from 12 commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
bd3e685
remove any unused loads and if we have a single store in a func, dele…
vezenovm Sep 4, 2024
260acd0
delete rc load tracker
vezenovm Sep 4, 2024
0c575fa
add test and separate logic into cleaner functions
vezenovm Sep 4, 2024
409fbff
clenaup
vezenovm Sep 4, 2024
0022639
update comment
vezenovm Sep 4, 2024
825b978
another comment improvement
vezenovm Sep 4, 2024
c8e6b02
Merge branch 'master' into mv/cleanup-loads-and-stores
vezenovm Sep 4, 2024
2856501
add back check that store address equals the load result address for …
vezenovm Sep 4, 2024
8473816
cargo fmt
vezenovm Sep 4, 2024
5636a52
change some panics to unreachables
TomAFrench Sep 5, 2024
60448ce
doc comment
TomAFrench Sep 5, 2024
e2ee004
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
TomAFrench Sep 5, 2024
5eb0cbc
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
50dd6bc
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
54fa3d3
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
d438f94
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
84c0fc1
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
f35f3a2
cargo fmt
vezenovm Sep 5, 2024
aff0511
fixup comment
vezenovm Sep 5, 2024
a6f5325
do not restructure in the final load results loop'
vezenovm Sep 5, 2024
2cdf253
conflicts w/ master after trivvial stores merge
vezenovm Sep 5, 2024
ce972bc
result_counter -> uses
vezenovm Sep 5, 2024
ac9c1d2
Update compiler/noirc_evaluator/src/ssa/opt/mem2reg.rs
vezenovm Sep 5, 2024
2bc7b8b
fmt
vezenovm Sep 5, 2024
399e6d9
PerFuncLastLoadContext
vezenovm Sep 5, 2024
ebfdc6d
switch back to always reinserting last_load
vezenovm Sep 5, 2024
4bbfc46
fmt
vezenovm Sep 5, 2024
d1d9ac4
Merge branch 'master' into mv/cleanup-loads-and-stores
TomAFrench Sep 6, 2024
2e7b450
Merge branch 'master' into mv/cleanup-loads-and-stores
vezenovm Sep 6, 2024
7613453
recursively check load results, additional test for load results used…
vezenovm Sep 9, 2024
f90c081
merge w/ master
vezenovm Sep 9, 2024
cec0c45
fix const in test
vezenovm Sep 9, 2024
9506f8b
nargo fmt
vezenovm Sep 9, 2024
5476eae
Merge branch 'master' into mv/cleanup-loads-and-stores
vezenovm Sep 10, 2024
df03d7d
dirty mem2reg changes to get things passing w/ aztec
vezenovm Sep 12, 2024
38f6268
merge w/ master
vezenovm Sep 12, 2024
9a6611a
handle all terminators and block params of a function + store uses hack
vezenovm Sep 13, 2024
ab0489a
nargo mft
vezenovm Sep 13, 2024
abc61fb
fix missing error
vezenovm Sep 13, 2024
bad6d1d
tiny cleanup
vezenovm Sep 13, 2024
fc35396
add todo
vezenovm Sep 13, 2024
166180a
Merge branch 'master' into mv/cleanup-loads-and-stores
vezenovm Sep 13, 2024
3290dcb
note that store_uses can be removed
vezenovm Sep 13, 2024
00f2f0e
fix tests
vezenovm Sep 13, 2024
e60d4ce
cargo fmt
vezenovm Sep 13, 2024
f90fd95
remove debugging prints
vezenovm Sep 13, 2024
2c32703
to get everything passing with aztec-packages, remove_unused_loads_an…
vezenovm Sep 13, 2024
6200597
add mut in test
vezenovm Sep 16, 2024
8232dae
remove last usage of store uses and add unit test for store only used…
vezenovm Sep 16, 2024
7cc78dc
improved checks
vezenovm Sep 16, 2024
9cd7ea6
some cleanup
vezenovm Sep 16, 2024
b6750e8
remove debugging stuff
vezenovm Sep 16, 2024
5997cdd
block references test in the debugger
vezenovm Sep 16, 2024
b2a435a
some cleanup
vezenovm Sep 17, 2024
f8ba8bf
Merge branch 'master' into mv/cleanup-loads-and-stores
vezenovm Sep 17, 2024
e107d33
move terminator collection to remove_unloaded_last_stores and add sto…
vezenovm Sep 17, 2024
af0a3c8
add doc comments
vezenovm Sep 17, 2024
97db534
rename references_testing to reference_only_used_as_alias
vezenovm Sep 17, 2024
447947a
cleanup comment
vezenovm Sep 17, 2024
ea858a1
move doc comments location
vezenovm Sep 17, 2024
2ef1d41
typo
vezenovm Sep 17, 2024
c760ace
clarity improvement
vezenovm Sep 17, 2024
b137682
one more comment improvement
vezenovm Sep 17, 2024
c73a25d
reference counter more explicitly
vezenovm Sep 17, 2024
fb18d7e
one more clearer sentence
vezenovm Sep 17, 2024
06c99e6
put renamed test in debugger ignored tests
vezenovm Sep 17, 2024
30a3d8c
missd nargo toml save
vezenovm Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading