Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perf): Remove stores with known values #5934

Closed

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Sep 4, 2024

Description

Problem*

Follow-up to #5925 and alternative to #5865

Working towards #4535

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Changes to Brillig bytecode sizes

Generated at commit: 417f58324146716bc82f3f83ae987a9e3088ccbb, compared to commit: 8473816ca3137aecb86ab3aef1350bfb9c208dd4

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
fold_numeric_generic_poseidon -81 ✅ -6.11%
no_predicates_numeric_generic_poseidon -81 ✅ -6.11%
poseidon2 -47 ✅ -11.08%

Full diff report 👇
Program Brillig opcodes (+/-) %
eddsa 67,462 (-34) -0.05%
regression_5252 36,339 (-34) -0.09%
nested_array_in_slice 1,641 (-4) -0.24%
slice_regex 7,275 (-25) -0.34%
fold_complex_outputs 1,010 (-7) -0.69%
uhashmap 25,920 (-788) -2.95%
hashmap 40,579 (-1,976) -4.64%
fold_numeric_generic_poseidon 1,244 (-81) -6.11%
no_predicates_numeric_generic_poseidon 1,244 (-81) -6.11%
poseidon2 377 (-47) -11.08%

@vezenovm
Copy link
Contributor Author

vezenovm commented Sep 4, 2024

Closing in favor of #5935 as to base off of master

@vezenovm vezenovm closed this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Changes to circuit sizes

Generated at commit: 417f58324146716bc82f3f83ae987a9e3088ccbb, compared to commit: 8473816ca3137aecb86ab3aef1350bfb9c208dd4

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_in_slice -36 ✅ -3.29% -36 ✅ -0.64%
hashmap -3,109 ✅ -3.18% -3,646 ✅ -2.32%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_in_slice 1,057 (-36) -3.29% 5,596 (-36) -0.64%
hashmap 94,642 (-3,109) -3.18% 153,248 (-3,646) -2.32%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant