Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let LSP suggest fields and methods in LValue chains #6051

Merged
merged 5 commits into from
Sep 16, 2024
Merged

fix: let LSP suggest fields and methods in LValue chains #6051

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a28f030
fix: let LSP suggest fields and methods in LValue chains
asterite Sep 16, 2024
1eb53d0
Handle more types, and do some refactors
asterite Sep 16, 2024
3957e4e
One more `follow_bindings`
asterite Sep 16, 2024
c7d54f4
follow_bindings in a different place
asterite Sep 16, 2024
80bfac1
Avoid calling `follow_bindings`
asterite Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tooling/lsp/src/requests/completion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
use super::process_request;

mod auto_import;
mod builtins;

Check warning on line 44 in tooling/lsp/src/requests/completion.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (builtins)
mod completion_items;
mod kinds;
mod sort_text;
Expand Down Expand Up @@ -233,7 +233,7 @@
let mut idents: Vec<Ident> = Vec::new();

// Find in which ident we are in, and in which part of it
// (it could be that we are completting in the middle of an ident)

Check warning on line 236 in tooling/lsp/src/requests/completion.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (completting)
for segment in &path.segments {
let ident = &segment.ident;

Expand Down Expand Up @@ -1559,7 +1559,7 @@
match typ {
Type::Array(_, typ) | Type::Slice(typ) => Some(*typ),
Type::Alias(alias_type, generics) => {
let typ = alias_type.borrow().get_type(&generics);
let typ = alias_type.borrow().get_type(&generics).follow_bindings();
jfecher marked this conversation as resolved.
Show resolved Hide resolved
get_array_element_type(typ)
}
_ => None,
Expand All @@ -1574,8 +1574,8 @@
///
/// For example:
///
/// // "merk" and "ro" match "merkle" and "root" and are in order

Check warning on line 1577 in tooling/lsp/src/requests/completion.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (merk)
/// name_matches("compute_merkle_root", "merk_ro") == true

Check warning on line 1578 in tooling/lsp/src/requests/completion.rs

View workflow job for this annotation

GitHub Actions / Code 

Unknown word (merk)
///
/// // "ro" matches "root", but "merkle" comes before it, so no match
/// name_matches("compute_merkle_root", "ro_mer") == false
Expand Down
Loading