Fix clippy warnings #614
Merged
Fix clippy warnings #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
previously approved these changes
Jan 10, 2023
5 tasks
kevaundray
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Clippy recently added a new warning suggesting to change
println!("foo {} baz", bar)toprintln!("foo {bar} baz"). The first style was used pervasively throughout our codebase so there were many changes required, most of which were automated withcargo clippy --fix.The codebase now checks without warnings on clippy
1.68.0-nightly.Alternatives
Alternatively, we can disable this lint in a toml file... somewhere.