feat: visibility for impl functions #6179

asterite · 2024-09-30T19:14:59Z

Description

Problem

Part of #4515

Summary

~~After searching for a while I found that to make this work we only needed to change one line~~

Additional Context

I didn't include tests for now, but I'll add them later because we first need to figure out which impl functions should be marked as pub or pub(crate) in the stdlib. I'm not familiar with the stdlib though I probably can't do it. That said, if you open the standard library with a nargo compiled from this PR you already get some warnings, so those functions should at least not be private.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

TomAFrench · 2024-10-01T16:23:08Z

turbofish_numeric_generic_nested_call is failing so it seems like private impl functions cannot be called from the same module (i.e. the functions are private to within the impl rather than to the module in which the impl sits)

asterite · 2024-10-01T16:29:06Z

Ah, right. I just bumped into this while trying to add some visibilities. It seems that also U128::method fails if you are inside U128, but it doesn't fail if you do Self::method 🤔 I'll take a look 😄

asterite · 2024-10-01T19:24:20Z

Done! All tests pass now. I think there are still some fns that could be made pub.

TomAFrench · 2024-10-02T11:50:42Z

This seems like a slightly different case to what I meant in my comment. I've pushed a new test case which I would expect to pass but doesn't.

…ng/noir into ab/visibility-for-impl-functions

asterite · 2024-10-02T15:17:42Z

I think I got it now! 😄

asterite · 2024-10-02T18:57:14Z

I noticed that visibility isn't checked for the new TypePath, which is something like Field::from_le_bytes where what's before :: isn't a Path but a Type. That requires different code to do it so I'd prefer to do it in a separate PR.

TomAFrench · 2024-10-02T23:57:55Z

Yeah, there's a good amount of stuff broken with type aliases due to this, a lot of issues related to type aliases stem from this #4469

asterite · 2024-10-03T09:59:14Z

I see.

Well, this is ready for review in case you want to take a look at it.

TomAFrench

One concern about a function we're making public but otherwise looks fine.

noir_stdlib/src/embedded_curve_ops.nr

feat: Inclusive for loop (noir-lang/noir#6200) chore: Release Noir(0.35.0) (noir-lang/noir#6030) chore: revert mistaken stack size change (noir-lang/noir#6212) chore: fix typo in code snippet (noir-lang/noir#6211) feat: Sync from aztec-packages (noir-lang/noir#6210) fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206) feat(perf): Optimize array set from get (noir-lang/noir#6207) chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204) fix: type variables by default should have Any kind (noir-lang/noir#6203) feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198) fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197) fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195) feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199) feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094) feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184) feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072) chore: Remove macros_api module (noir-lang/noir#6190) fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084) chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)

…ang/noir#6205) fix: don't warn twice when referring to private item (noir-lang/noir#6216) feat: visibility for impl functions (noir-lang/noir#6179) feat: Inclusive for loop (noir-lang/noir#6200) chore: Release Noir(0.35.0) (noir-lang/noir#6030) chore: revert mistaken stack size change (noir-lang/noir#6212) chore: fix typo in code snippet (noir-lang/noir#6211) feat: Sync from aztec-packages (noir-lang/noir#6210) fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206) feat(perf): Optimize array set from get (noir-lang/noir#6207) chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204) fix: type variables by default should have Any kind (noir-lang/noir#6203) feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198) fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197) fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195) feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199) feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094) feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184) feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072) chore: Remove macros_api module (noir-lang/noir#6190) fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084) chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)

fix: don't warn twice when referring to private item (noir-lang/noir#6216) feat: visibility for impl functions (noir-lang/noir#6179) feat: Inclusive for loop (noir-lang/noir#6200) chore: Release Noir(0.35.0) (noir-lang/noir#6030) chore: revert mistaken stack size change (noir-lang/noir#6212) chore: fix typo in code snippet (noir-lang/noir#6211) feat: Sync from aztec-packages (noir-lang/noir#6210) fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206) feat(perf): Optimize array set from get (noir-lang/noir#6207) chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204) fix: type variables by default should have Any kind (noir-lang/noir#6203) feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198) fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197) fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195) feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199) feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094) feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184) feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072) chore: Remove macros_api module (noir-lang/noir#6190) fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084) chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: visibility for impl functions (noir-lang/noir#6179) feat: Inclusive for loop (noir-lang/noir#6200) chore: Release Noir(0.35.0) (noir-lang/noir#6030) chore: revert mistaken stack size change (noir-lang/noir#6212) chore: fix typo in code snippet (noir-lang/noir#6211) feat: Sync from aztec-packages (noir-lang/noir#6210) fix: ignore compression of blocks after msg.len in sha256_var (noir-lang/noir#6206) feat(perf): Optimize array set from get (noir-lang/noir#6207) chore(refactor): Array set optimization context struct for analysis (noir-lang/noir#6204) fix: type variables by default should have Any kind (noir-lang/noir#6203) feat: remove orphaned blocks from cfg to improve `simplify_cfg` pass. (noir-lang/noir#6198) fix(ssa): Check if result of array set is used in value of another array set (noir-lang/noir#6197) fix(docs): Rename recursion.md to recursion.mdx (noir-lang/noir#6195) feat: skip `remove_enable_side_effects` pass on brillig functions (noir-lang/noir#6199) feat!: Syncing TypeVariableKind with Kind (noir-lang/noir#6094) feat(perf): Simplify the cfg after DIE (noir-lang/noir#6184) feat: refactor SSA passes to run on individual functions (noir-lang/noir#6072) chore: Remove macros_api module (noir-lang/noir#6190) fix: ensure to_bytes returns the canonical decomposition (noir-lang/noir#6084) chore: rename `DefinitionKind::GenericType` (noir-lang/noir#6182) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <tom@tomfren.ch>

:robot: I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.57.0</summary> ## [0.57.0](https://github.com/AztecProtocol/aztec-packages/compare/aztec-package-v0.56.0...aztec-package-v0.57.0) (2024-10-07) ### Features * Consolidate spartan metrics ([#9037](https://github.com/AztecProtocol/aztec-packages/issues/9037)) ([0cff28b](https://github.com/AztecProtocol/aztec-packages/commit/0cff28b7582c0bccde453c86e05af23121011dfe)) * Proposers claim proving rights ([#8832](https://github.com/AztecProtocol/aztec-packages/issues/8832)) ([f8b0802](https://github.com/AztecProtocol/aztec-packages/commit/f8b0802b72d7db864d55ed12939f63670e46d71f)) * Prover escrow and 712-signed quotes ([#8877](https://github.com/AztecProtocol/aztec-packages/issues/8877)) ([2f1d19a](https://github.com/AztecProtocol/aztec-packages/commit/2f1d19ac3baa35800ac941f0941461addad7ab66)) * Prover node sends quotes on new epochs ([#8864](https://github.com/AztecProtocol/aztec-packages/issues/8864)) ([4adf860](https://github.com/AztecProtocol/aztec-packages/commit/4adf8600dab5b7e177b84b6920674024c01b4e25)), closes [#8684](https://github.com/AztecProtocol/aztec-packages/issues/8684) [#8683](https://github.com/AztecProtocol/aztec-packages/issues/8683) * Prover node stakes to escrow contract ([#8975](https://github.com/AztecProtocol/aztec-packages/issues/8975)) ([9eb8815](https://github.com/AztecProtocol/aztec-packages/commit/9eb8815dc00641d6568e952b336e6f7348728054)) ### Bug Fixes * L1 request intervals ([#8997](https://github.com/AztecProtocol/aztec-packages/issues/8997)) ([780fd62](https://github.com/AztecProtocol/aztec-packages/commit/780fd6210d0b1f8fc386135082ef443b449b3cdf)) ### Miscellaneous * Add memoize decorator ([#8976](https://github.com/AztecProtocol/aztec-packages/issues/8976)) ([1d9711b](https://github.com/AztecProtocol/aztec-packages/commit/1d9711b0a145f47bfe6d4d64b6837873e2725d2f)) * Bump foundry ([#8868](https://github.com/AztecProtocol/aztec-packages/issues/8868)) ([bfd0b8e](https://github.com/AztecProtocol/aztec-packages/commit/bfd0b8e6932c2b2fdf6e1c35c3c324edec92118a)) * Fix the transfer test we run in kind clusters ([#8796](https://github.com/AztecProtocol/aztec-packages/issues/8796)) ([7c42ef0](https://github.com/AztecProtocol/aztec-packages/commit/7c42ef09bfc006c1d9725ac89e315d9a84c430fc)) * Remove mock proof commitment escrow ([#9011](https://github.com/AztecProtocol/aztec-packages/issues/9011)) ([4873c7b](https://github.com/AztecProtocol/aztec-packages/commit/4873c7bc850092e2962fcaf747ec60f19e89ba92)) </details> <details><summary>barretenberg.js: 0.57.0</summary> ## [0.57.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg.js-v0.56.0...barretenberg.js-v0.57.0) (2024-10-07) ### Features * Add crsPath to BackendOptions ([#8775](https://github.com/AztecProtocol/aztec-packages/issues/8775)) ([78fa676](https://github.com/AztecProtocol/aztec-packages/commit/78fa676eda1c6b35fe843e72347a77f9f6d89fa4)) * CI/local S3 build cache ([#8802](https://github.com/AztecProtocol/aztec-packages/issues/8802)) ([06be26e](https://github.com/AztecProtocol/aztec-packages/commit/06be26e2b5dfd4b1fa35f57231e15ebffbe410a7)) * Use structured polys to reduce prover memory ([#8587](https://github.com/AztecProtocol/aztec-packages/issues/8587)) ([59e3dd9](https://github.com/AztecProtocol/aztec-packages/commit/59e3dd93a70398e828269dbf13d8c4b9b38227ea)) ### Bug Fixes * **avm:** Kernel out full proving fix ([#8873](https://github.com/AztecProtocol/aztec-packages/issues/8873)) ([784d483](https://github.com/AztecProtocol/aztec-packages/commit/784d483b592cb80da143634c07d330ba2f2c9ab7)) * **CI:** Yarn-project publish_npm script ([#8996](https://github.com/AztecProtocol/aztec-packages/issues/8996)) ([dc87b0e](https://github.com/AztecProtocol/aztec-packages/commit/dc87b0e9c33d59924368341f765c7a5fedf420d2)) ### Miscellaneous * Publish bb.js in github action ([#8959](https://github.com/AztecProtocol/aztec-packages/issues/8959)) ([a21ab89](https://github.com/AztecProtocol/aztec-packages/commit/a21ab8915937b3c3f98551fb078c9874f2ed1547)) * Push proof splitting helpers into bb.js ([#8795](https://github.com/AztecProtocol/aztec-packages/issues/8795)) ([951ce6d](https://github.com/AztecProtocol/aztec-packages/commit/951ce6d974504f0453ad2816d10c358d8ef02ce5)) </details> <details><summary>aztec-packages: 0.57.0</summary> ## [0.57.0](https://github.com/AztecProtocol/aztec-packages/compare/aztec-packages-v0.56.0...aztec-packages-v0.57.0) (2024-10-07) ### ⚠ BREAKING CHANGES * refactor contract interaction pt.1 ([#8938](https://github.com/AztecProtocol/aztec-packages/issues/8938)) * **avm:** remove CMOV opcode ([#9030](https://github.com/AztecProtocol/aztec-packages/issues/9030)) * **public:** only deploy/register public_dispatch ([#8988](https://github.com/AztecProtocol/aztec-packages/issues/8988)) * Syncing TypeVariableKind with Kind (https://github.com/noir-lang/noir/pull/6094) * **public:** reroute public calls to dispatch function ([#8972](https://github.com/AztecProtocol/aztec-packages/issues/8972)) * **avm:** make indirects big enough for relative addressing ([#9000](https://github.com/AztecProtocol/aztec-packages/issues/9000)) * keccak_ultra -> ultra_keccak ([#8878](https://github.com/AztecProtocol/aztec-packages/issues/8878)) * rename unsafe_rand, misc log unsafe changes ([#8844](https://github.com/AztecProtocol/aztec-packages/issues/8844)) * switch slot derivation to poseidon2 instead of pedersen ([#8801](https://github.com/AztecProtocol/aztec-packages/issues/8801)) * fix storage layout export ([#8880](https://github.com/AztecProtocol/aztec-packages/issues/8880)) * remove SharedMutablePrivateGetter ([#8749](https://github.com/AztecProtocol/aztec-packages/issues/8749)) ### Features * Add CLI command to advance epoch ([#9014](https://github.com/AztecProtocol/aztec-packages/issues/9014)) ([36f6187](https://github.com/AztecProtocol/aztec-packages/commit/36f6187eb8cd9aea804b1404d7b5baf8945133bc)) * Add crsPath to BackendOptions ([#8775](https://github.com/AztecProtocol/aztec-packages/issues/8775)) ([78fa676](https://github.com/AztecProtocol/aztec-packages/commit/78fa676eda1c6b35fe843e72347a77f9f6d89fa4)) * Add support for unlimited width in ACIR ([#8960](https://github.com/AztecProtocol/aztec-packages/issues/8960)) ([3e05e22](https://github.com/AztecProtocol/aztec-packages/commit/3e05e22d8d9fc73c1225570342392dda5661403f)) * Adding CPU / RAM configurations to helm network deployments ([#8786](https://github.com/AztecProtocol/aztec-packages/issues/8786)) ([7790ede](https://github.com/AztecProtocol/aztec-packages/commit/7790ede48933d2f831089be4375fd62081d72d77)) * Allow silencing an unused variable defined via `let` (https://github.com/noir-lang/noir/pull/6149) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * **avm:** Integrate public inputs in AVM recursive verifier ([#8846](https://github.com/AztecProtocol/aztec-packages/issues/8846)) ([4354ae0](https://github.com/AztecProtocol/aztec-packages/commit/4354ae030b5b7e365ff0361e88cd74cd95d71e04)), closes [#8714](https://github.com/AztecProtocol/aztec-packages/issues/8714) * **avm:** Simulator relative addr ([#8837](https://github.com/AztecProtocol/aztec-packages/issues/8837)) ([dda528a](https://github.com/AztecProtocol/aztec-packages/commit/dda528a2f1ca1a52ce08f6175b594f6567fc370e)) * **avm:** Skip gas accounting for fake rows ([#8944](https://github.com/AztecProtocol/aztec-packages/issues/8944)) ([818325a](https://github.com/AztecProtocol/aztec-packages/commit/818325ae35ce0260d88e097261d173f4dc326cbe)), closes [#8903](https://github.com/AztecProtocol/aztec-packages/issues/8903) * **aztec-nr/public:** Dispatch function ([#8821](https://github.com/AztecProtocol/aztec-packages/issues/8821)) ([3af2381](https://github.com/AztecProtocol/aztec-packages/commit/3af238177ef273bec36c1faccad80ccc9cfed192)) * CI/local S3 build cache ([#8802](https://github.com/AztecProtocol/aztec-packages/issues/8802)) ([06be26e](https://github.com/AztecProtocol/aztec-packages/commit/06be26e2b5dfd4b1fa35f57231e15ebffbe410a7)) * Connect the public inputs but not the proof in ivc recursion constraints ([#8973](https://github.com/AztecProtocol/aztec-packages/issues/8973)) ([4f1af9a](https://github.com/AztecProtocol/aztec-packages/commit/4f1af9a0baf9e342d0de41ebd58fed24a0c4f615)) * Consolidate spartan metrics ([#9037](https://github.com/AztecProtocol/aztec-packages/issues/9037)) ([0cff28b](https://github.com/AztecProtocol/aztec-packages/commit/0cff28b7582c0bccde453c86e05af23121011dfe)) * Delivering partial fields via unencrypted logs ([#8725](https://github.com/AztecProtocol/aztec-packages/issues/8725)) ([8a59b17](https://github.com/AztecProtocol/aztec-packages/commit/8a59b176545ba6d0eed434cba50c9d5c745cfd25)) * Detect unconstructed structs (https://github.com/noir-lang/noir/pull/6061) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Documenting note macros ([#9009](https://github.com/AztecProtocol/aztec-packages/issues/9009)) ([623b1dd](https://github.com/AztecProtocol/aztec-packages/commit/623b1dd7130360c2dde5e221fc560e80973daa52)) * Empty block root circuit ([#8805](https://github.com/AztecProtocol/aztec-packages/issues/8805)) ([b5fc91c](https://github.com/AztecProtocol/aztec-packages/commit/b5fc91c305bf0ea8935faa2e754a5d390d4f40a1)) * Enforce limits for each side effect type in AVM ([#8889](https://github.com/AztecProtocol/aztec-packages/issues/8889)) ([57d5cfd](https://github.com/AztecProtocol/aztec-packages/commit/57d5cfd1e6936066a72dad312dfea6032ebd4e72)) * Expose `derived_generators` and `pedersen_commitment_with_separator` from the stdlib (https://github.com/noir-lang/noir/pull/6154) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Faster CIV benching with mocked VKs ([#8843](https://github.com/AztecProtocol/aztec-packages/issues/8843)) ([fad3d6e](https://github.com/AztecProtocol/aztec-packages/commit/fad3d6e41765c774696ecc98d45a27851c7c4442)) * Handle consecutive kernels in IVC ([#8924](https://github.com/AztecProtocol/aztec-packages/issues/8924)) ([0be9f25](https://github.com/AztecProtocol/aztec-packages/commit/0be9f253238cc1453d07385ece565f946d4212a3)) * Handle epoch proofs on L1 ([#8704](https://github.com/AztecProtocol/aztec-packages/issues/8704)) ([730f23c](https://github.com/AztecProtocol/aztec-packages/commit/730f23c4965d5aed266654f9fbad3269542fb186)) * Hoist constant allocation outside of loops (https://github.com/noir-lang/noir/pull/6158) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Inclusive for loop (https://github.com/noir-lang/noir/pull/6200) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Lazy commitment key allocation for better memory ([#9017](https://github.com/AztecProtocol/aztec-packages/issues/9017)) ([527d820](https://github.com/AztecProtocol/aztec-packages/commit/527d820fcadc24105e43b819da1ad9d848b755ca)) * Let `Module::functions` and `Module::structs` return them in definition order (https://github.com/noir-lang/noir/pull/6178) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Make shplemini proof constant ([#8826](https://github.com/AztecProtocol/aztec-packages/issues/8826)) ([c8cbc33](https://github.com/AztecProtocol/aztec-packages/commit/c8cbc3388c2bbe9a0ba8a95717e1b71c602d58e3)) * New Tracy Time preset and more efficient univariate extension ([#8789](https://github.com/AztecProtocol/aztec-packages/issues/8789)) ([ead4649](https://github.com/AztecProtocol/aztec-packages/commit/ead4649b0c21a98534c36e7755edac68052b3c26)) * Note fields in TS artifact ([#8906](https://github.com/AztecProtocol/aztec-packages/issues/8906)) ([7f40411](https://github.com/AztecProtocol/aztec-packages/commit/7f404118af0e81233b4c4b546260ed6fb59c1f3c)) * Nullable note fields info in ABI ([#8901](https://github.com/AztecProtocol/aztec-packages/issues/8901)) ([e0d5e06](https://github.com/AztecProtocol/aztec-packages/commit/e0d5e06d8fc30cbdda7e4102dbf3412808382377)) * Origin Tags part 1 ([#8787](https://github.com/AztecProtocol/aztec-packages/issues/8787)) ([ed1e23e](https://github.com/AztecProtocol/aztec-packages/commit/ed1e23edff04ea026a94ffc22b29b6ef520cdf55)) * Origin Tags Part 2 ([#8936](https://github.com/AztecProtocol/aztec-packages/issues/8936)) ([77c05f5](https://github.com/AztecProtocol/aztec-packages/commit/77c05f5469bad85e1394c05e1878791bac084559)) * Partial note log support in macros ([#8951](https://github.com/AztecProtocol/aztec-packages/issues/8951)) ([f3c1eaa](https://github.com/AztecProtocol/aztec-packages/commit/f3c1eaa8212ef0c8cf41e8fa7d0b41a666143bb4)) * **perf:** Handle array set optimization across blocks for Brillig functions (https://github.com/noir-lang/noir/pull/6153) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * **perf:** Optimize array set from get (https://github.com/noir-lang/noir/pull/6207) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * **perf:** Remove inc_rc instructions for arrays which are never mutably borrowed (https://github.com/noir-lang/noir/pull/6168) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * **perf:** Remove redundant inc rc without instructions between (https://github.com/noir-lang/noir/pull/6183) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * **perf:** Remove useless paired RC instructions within a block during DIE (https://github.com/noir-lang/noir/pull/6160) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * **perf:** Simplify the cfg after DIE (https://github.com/noir-lang/noir/pull/6184) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Proposers claim proving rights ([#8832](https://github.com/AztecProtocol/aztec-packages/issues/8832)) ([f8b0802](https://github.com/AztecProtocol/aztec-packages/commit/f8b0802b72d7db864d55ed12939f63670e46d71f)) * Prover escrow and 712-signed quotes ([#8877](https://github.com/AztecProtocol/aztec-packages/issues/8877)) ([2f1d19a](https://github.com/AztecProtocol/aztec-packages/commit/2f1d19ac3baa35800ac941f0941461addad7ab66)) * Prover node sends quotes on new epochs ([#8864](https://github.com/AztecProtocol/aztec-packages/issues/8864)) ([4adf860](https://github.com/AztecProtocol/aztec-packages/commit/4adf8600dab5b7e177b84b6920674024c01b4e25)), closes [#8684](https://github.com/AztecProtocol/aztec-packages/issues/8684) [#8683](https://github.com/AztecProtocol/aztec-packages/issues/8683) * Prover node stakes to escrow contract ([#8975](https://github.com/AztecProtocol/aztec-packages/issues/8975)) ([9eb8815](https://github.com/AztecProtocol/aztec-packages/commit/9eb8815dc00641d6568e952b336e6f7348728054)) * Prover node submits epoch proofs ([#8794](https://github.com/AztecProtocol/aztec-packages/issues/8794)) ([1612909](https://github.com/AztecProtocol/aztec-packages/commit/161290925978fdcb6321a7d0b6c5d5b2ca6fd837)) * **public:** Only deploy/register public_dispatch ([#8988](https://github.com/AztecProtocol/aztec-packages/issues/8988)) ([6c30453](https://github.com/AztecProtocol/aztec-packages/commit/6c3045332ea44cf16b04918d321e8dcda28c0adf)) * **public:** Reroute public calls to dispatch function ([#8972](https://github.com/AztecProtocol/aztec-packages/issues/8972)) ([c4297ce](https://github.com/AztecProtocol/aztec-packages/commit/c4297ced66b977eab3ba52707ef45ddea3f19ee4)) * Refactor contract interaction pt.1 ([#8938](https://github.com/AztecProtocol/aztec-packages/issues/8938)) ([62963f9](https://github.com/AztecProtocol/aztec-packages/commit/62963f9cb30fc6e0187e79ad4e7d49653a937b80)) * Refactor SSA passes to run on individual functions (https://github.com/noir-lang/noir/pull/6072) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Remote quote provider ([#8946](https://github.com/AztecProtocol/aztec-packages/issues/8946)) ([1c3cb63](https://github.com/AztecProtocol/aztec-packages/commit/1c3cb63c45f5ee6605911ecc0cc2524aef67391c)) * Remove orphaned blocks from cfg to improve `simplify_cfg` pass. (https://github.com/noir-lang/noir/pull/6198) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Remove SharedMutablePrivateGetter ([#8749](https://github.com/AztecProtocol/aztec-packages/issues/8749)) ([154d396](https://github.com/AztecProtocol/aztec-packages/commit/154d396b5344ef5a032bdfe11858c8f0e69ce2bb)) * Rename unsafe_rand, misc log unsafe changes ([#8844](https://github.com/AztecProtocol/aztec-packages/issues/8844)) ([81a4d74](https://github.com/AztecProtocol/aztec-packages/commit/81a4d74c3200823cdb41125b8c98964dc3fdc1e8)) * Reset circuit variants ([#8876](https://github.com/AztecProtocol/aztec-packages/issues/8876)) ([415d78f](https://github.com/AztecProtocol/aztec-packages/commit/415d78f80ebd65b9a824dfc9958788de426e805a)) * Simplify sha256 implementation (https://github.com/noir-lang/noir/pull/6142) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Skip `remove_enable_side_effects` pass on brillig functions (https://github.com/noir-lang/noir/pull/6199) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Snapshotting for e2e p2p tests ([#8896](https://github.com/AztecProtocol/aztec-packages/issues/8896)) ([ebb86b7](https://github.com/AztecProtocol/aztec-packages/commit/ebb86b7f453315afc3116fbf9aeecca8ff39961c)) * **sol:** Add shplemini transcript ([#8865](https://github.com/AztecProtocol/aztec-packages/issues/8865)) ([089dbad](https://github.com/AztecProtocol/aztec-packages/commit/089dbadd9e9ca304004c38e01d3703d923b257ec)) * **sol:** Shplemini verification ([#8866](https://github.com/AztecProtocol/aztec-packages/issues/8866)) ([989eb08](https://github.com/AztecProtocol/aztec-packages/commit/989eb08256db49e65e2d5e8a91790f941761d08f)) * **ssa:** Simplify signed casts (https://github.com/noir-lang/noir/pull/6166) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Stronger typing in L1 contracts ([#8841](https://github.com/AztecProtocol/aztec-packages/issues/8841)) ([0b5aaea](https://github.com/AztecProtocol/aztec-packages/commit/0b5aaea7f28061abdae77e2de8e6a10c1b887a7e)) * Switch slot derivation to poseidon2 instead of pedersen ([#8801](https://github.com/AztecProtocol/aztec-packages/issues/8801)) ([e3e0b6f](https://github.com/AztecProtocol/aztec-packages/commit/e3e0b6f196afc7fd9c4ed1f5d65cabb634258dcd)) * Sync from aztec-packages (https://github.com/noir-lang/noir/pull/6151) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Sync from aztec-packages (https://github.com/noir-lang/noir/pull/6210) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Syncing TypeVariableKind with Kind (https://github.com/noir-lang/noir/pull/6094) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Trace AVM side effects per enqueued call ([#8918](https://github.com/AztecProtocol/aztec-packages/issues/8918)) ([c1a95db](https://github.com/AztecProtocol/aztec-packages/commit/c1a95db2aa3e692f8fb767b251f18572a8fd81cc)) * Ultra honk on Shplemini ([#8886](https://github.com/AztecProtocol/aztec-packages/issues/8886)) ([d8d04f6](https://github.com/AztecProtocol/aztec-packages/commit/d8d04f6f0b9ca0aa36008dc53dde2562dc3afa63)) * Use structured polys to reduce prover memory ([#8587](https://github.com/AztecProtocol/aztec-packages/issues/8587)) ([59e3dd9](https://github.com/AztecProtocol/aztec-packages/commit/59e3dd93a70398e828269dbf13d8c4b9b38227ea)) * Visibility for globals (https://github.com/noir-lang/noir/pull/6161) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Visibility for impl functions (https://github.com/noir-lang/noir/pull/6179) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Visibility for modules (https://github.com/noir-lang/noir/pull/6165) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Visibility for type aliases (https://github.com/noir-lang/noir/pull/6058) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) ### Bug Fixes * (LSP) make goto and hover work well for attributes (https://github.com/noir-lang/noir/pull/6152) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Add epoch proof quote to json rpc serialization ([#9013](https://github.com/AztecProtocol/aztec-packages/issues/9013)) ([da2106f](https://github.com/AztecProtocol/aztec-packages/commit/da2106f1d7dab24f4b6e34bcb7c884e61e1e98c0)) * Add missing visibility for auto-import names (https://github.com/noir-lang/noir/pull/6205) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Add persistent storage for aztec nodes in the spartan cluster ([#8923](https://github.com/AztecProtocol/aztec-packages/issues/8923)) ([23786be](https://github.com/AztecProtocol/aztec-packages/commit/23786be68cdb6f35b6919cde5af57ab70f9741ad)) * Add values file as an arg to the earthly command ([#8857](https://github.com/AztecProtocol/aztec-packages/issues/8857)) ([3c15da3](https://github.com/AztecProtocol/aztec-packages/commit/3c15da3132b6605cf0ad451b79ac3e688e18d938)) * Archiver getBlocksForEpoch and EpochProvingJob on block 1 ([#9016](https://github.com/AztecProtocol/aztec-packages/issues/9016)) ([9669db0](https://github.com/AztecProtocol/aztec-packages/commit/9669db07392b9feeca2789aca181aec58dddcfec)) * Arm build ([#8870](https://github.com/AztecProtocol/aztec-packages/issues/8870)) ([e4c5be8](https://github.com/AztecProtocol/aztec-packages/commit/e4c5be890049a897a3b1dddc95ed910b847f16b7)) * Assign one_idx in the same place as zero_idx in `UltraCircuitBuilder` ([#9029](https://github.com/AztecProtocol/aztec-packages/issues/9029)) ([fe11d9a](https://github.com/AztecProtocol/aztec-packages/commit/fe11d9a3a1b96454999ae627c902d8b362805172)) * Attestation pool ([#8854](https://github.com/AztecProtocol/aztec-packages/issues/8854)) ([ffbad35](https://github.com/AztecProtocol/aztec-packages/commit/ffbad355381f9db85a8dbb339af1b190e0ced3aa)) * Attestations are requested based on their proposal not just slot ([#8442](https://github.com/AztecProtocol/aztec-packages/issues/8442)) ([08d8578](https://github.com/AztecProtocol/aztec-packages/commit/08d8578d3f36a809fa415ab745f65e61ba575be1)) * **avm:** CALL operand resolution ([#9018](https://github.com/AztecProtocol/aztec-packages/issues/9018)) ([7f2e29f](https://github.com/AztecProtocol/aztec-packages/commit/7f2e29fd0042d7644e629dfe660533c681bf71a8)) * **avm:** Kernel out full proving fix ([#8873](https://github.com/AztecProtocol/aztec-packages/issues/8873)) ([784d483](https://github.com/AztecProtocol/aztec-packages/commit/784d483b592cb80da143634c07d330ba2f2c9ab7)) * **avm:** MSM not including enough operands ([#9004](https://github.com/AztecProtocol/aztec-packages/issues/9004)) ([830c6ab](https://github.com/AztecProtocol/aztec-packages/commit/830c6ab464d3e2ccd36d010072b89cb0b4ebdb16)) * Bb.js acir tests ([#8862](https://github.com/AztecProtocol/aztec-packages/issues/8862)) ([d8d0541](https://github.com/AztecProtocol/aztec-packages/commit/d8d0541bde1d98d6b7ae3c3bb2a38068383f802b)) * Bug in slot to timestamp conversion ([#8839](https://github.com/AztecProtocol/aztec-packages/issues/8839)) ([d9baebe](https://github.com/AztecProtocol/aztec-packages/commit/d9baebe9cf343bc47da5b99abc17cef2f76d875f)) * Call generate-variants on noir-projects bootstrap fast ([#8956](https://github.com/AztecProtocol/aztec-packages/issues/8956)) ([2570b59](https://github.com/AztecProtocol/aztec-packages/commit/2570b59aee921a23841e135bde9b85fd67b442e6)) * **ci:** Do not post public functions report when empty ([#8790](https://github.com/AztecProtocol/aztec-packages/issues/8790)) ([507710f](https://github.com/AztecProtocol/aztec-packages/commit/507710f3a77e0277b1c17ed7341715bc023f8c5d)) * Circleci ([#9056](https://github.com/AztecProtocol/aztec-packages/issues/9056)) ([5c77c4f](https://github.com/AztecProtocol/aztec-packages/commit/5c77c4f63b2d69c5e28feade2056facafe859e03)) * **CI:** Yarn-project publish_npm script ([#8996](https://github.com/AztecProtocol/aztec-packages/issues/8996)) ([dc87b0e](https://github.com/AztecProtocol/aztec-packages/commit/dc87b0e9c33d59924368341f765c7a5fedf420d2)) * Databus panic for fns with empty params ([#8847](https://github.com/AztecProtocol/aztec-packages/issues/8847)) ([6a13290](https://github.com/AztecProtocol/aztec-packages/commit/6a132906ec8653cec7f30af2e008c8881d42db46)) * Disable flakey test ([#8927](https://github.com/AztecProtocol/aztec-packages/issues/8927)) ([151bb79](https://github.com/AztecProtocol/aztec-packages/commit/151bb79add3dfff059ccadee7c0bc25cc9059440)) * Do not assume blocks as proven in e2e-prover tests ([#8848](https://github.com/AztecProtocol/aztec-packages/issues/8848)) ([2d5ae66](https://github.com/AztecProtocol/aztec-packages/commit/2d5ae664964b66c4b617965fe85488e95706a8d3)) * Do not duplicate constant arrays in brillig (https://github.com/noir-lang/noir/pull/6155) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Do not start block root rollup proof before block is built ([#8952](https://github.com/AztecProtocol/aztec-packages/issues/8952)) ([af1a6af](https://github.com/AztecProtocol/aztec-packages/commit/af1a6af29cc9af8c24df964bcfde83b4064db7ac)) * **docs:** Rename recursion.md to recursion.mdx (https://github.com/noir-lang/noir/pull/6195) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * **docs:** Update private_voting_contract.md ([#9010](https://github.com/AztecProtocol/aztec-packages/issues/9010)) ([86afa81](https://github.com/AztecProtocol/aztec-packages/commit/86afa81d744bcf0c3ffd732663a24234b26e8aa8)) * Don't warn twice when referring to private item (https://github.com/noir-lang/noir/pull/6216) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Earthly-local ([#8915](https://github.com/AztecProtocol/aztec-packages/issues/8915)) ([9b3da97](https://github.com/AztecProtocol/aztec-packages/commit/9b3da97668209b89af4a04343ccc5f4b512c4127)) * Earthly-script output ([#8871](https://github.com/AztecProtocol/aztec-packages/issues/8871)) ([a02370c](https://github.com/AztecProtocol/aztec-packages/commit/a02370c1738c70ea8c6300c43a396f310cd2e017)) * Ensure to_bytes returns the canonical decomposition (https://github.com/noir-lang/noir/pull/6084) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * **external PR, twt--:** Remove quotes $artifacts_to_transpile in the for loop list of compile_then_transpile.sh ([#8932](https://github.com/AztecProtocol/aztec-packages/issues/8932)) ([95cb977](https://github.com/AztecProtocol/aztec-packages/commit/95cb97755e7efa549930c47e2eb6f9fb5ba4020f)) * **external PR, twt--:** Un-nest docker compose variable substitution in sandbox config ([#8930](https://github.com/AztecProtocol/aztec-packages/issues/8930)) ([12b8526](https://github.com/AztecProtocol/aztec-packages/commit/12b852683334f74683f69d1114e7d8562a289d39)) * **external PR, twt--:** Update .aztec-run to run in non-interactive mode if NON_INTERACTIVE is set to non-zero ([#8931](https://github.com/AztecProtocol/aztec-packages/issues/8931)) ([d85a66d](https://github.com/AztecProtocol/aztec-packages/commit/d85a66d4b0a610a3704a7f7f83dead507af6b586)) * Fix storage layout export ([#8880](https://github.com/AztecProtocol/aztec-packages/issues/8880)) ([c8f43b3](https://github.com/AztecProtocol/aztec-packages/commit/c8f43b3b3ea37c015a284868a06bebc1422bb34b)) * Flaky e2e sample dapp and quick start ([#8768](https://github.com/AztecProtocol/aztec-packages/issues/8768)) ([48914ba](https://github.com/AztecProtocol/aztec-packages/commit/48914ba71039f18d7cea9fca65997c2a6e263b25)) * Handle more types in size_in_fields, and panic on unexpected type ([#8887](https://github.com/AztecProtocol/aztec-packages/issues/8887)) ([03280e9](https://github.com/AztecProtocol/aztec-packages/commit/03280e9d78eaf395bb3f3c514c794bd0fa0af240)) * Ignore compression of blocks after msg.len in sha256_var (https://github.com/noir-lang/noir/pull/6206) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * L1 request intervals ([#8997](https://github.com/AztecProtocol/aztec-packages/issues/8997)) ([780fd62](https://github.com/AztecProtocol/aztec-packages/commit/780fd6210d0b1f8fc386135082ef443b449b3cdf)) * Nightly-kind-test.yml ([#8899](https://github.com/AztecProtocol/aztec-packages/issues/8899)) ([2bb9ca6](https://github.com/AztecProtocol/aztec-packages/commit/2bb9ca6f4ef43e2e405934c748831dc5e81a58c8)) * Pass radix directly to the blackbox (https://github.com/noir-lang/noir/pull/6164) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * **public:** Stack trace short term hack ([#9024](https://github.com/AztecProtocol/aztec-packages/issues/9024)) ([f2ea42c](https://github.com/AztecProtocol/aztec-packages/commit/f2ea42cbdb1a1f57f407874f8598129886c88494)) * Reenable CI reruns on master ([#8907](https://github.com/AztecProtocol/aztec-packages/issues/8907)) ([124307d](https://github.com/AztecProtocol/aztec-packages/commit/124307df3b8252913bcafed897050e2dbb00c331)) * Remove extra `crate::` ([#8909](https://github.com/AztecProtocol/aztec-packages/issues/8909)) ([fd0e945](https://github.com/AztecProtocol/aztec-packages/commit/fd0e9455ac667366f060a3b9d955b075adb8c5da)) * Rerun.yml ([#8913](https://github.com/AztecProtocol/aztec-packages/issues/8913)) ([b363738](https://github.com/AztecProtocol/aztec-packages/commit/b363738bfa040a8381b754bdf6a8754280532ea2)) * Setup publish action ([#8992](https://github.com/AztecProtocol/aztec-packages/issues/8992)) ([65f7e9f](https://github.com/AztecProtocol/aztec-packages/commit/65f7e9f84c28e49cbf2eff29a0b6090974509145)) * Spartan kubernetes cluster IaC ([#8893](https://github.com/AztecProtocol/aztec-packages/issues/8893)) ([7f5ff5e](https://github.com/AztecProtocol/aztec-packages/commit/7f5ff5e629f708a73a9d78f45c8fa195c6fca6dd)) * Specify correct env var in prover node helm ([#8916](https://github.com/AztecProtocol/aztec-packages/issues/8916)) ([6e855a4](https://github.com/AztecProtocol/aztec-packages/commit/6e855a47f900a207fdb015d322d5e4e61116df15)) * **ssa:** Check if result of array set is used in value of another array set (https://github.com/noir-lang/noir/pull/6197) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Temporarily disable problematic test ([#9051](https://github.com/AztecProtocol/aztec-packages/issues/9051)) ([7ee7f55](https://github.com/AztecProtocol/aztec-packages/commit/7ee7f55b23982f44b9c86b622eacc7ed820900c5)) * Type variables by default should have Any kind (https://github.com/noir-lang/noir/pull/6203) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Use different rust toolchain for foundry builds ([#8869](https://github.com/AztecProtocol/aztec-packages/issues/8869)) ([096a0b2](https://github.com/AztecProtocol/aztec-packages/commit/096a0b265f25c843cb7268c0dff25848ae0dabb9)) * Use properly sized p2p id ([#9040](https://github.com/AztecProtocol/aztec-packages/issues/9040)) ([9fe7436](https://github.com/AztecProtocol/aztec-packages/commit/9fe74367d05d3d6fc9006ed4341a39cbe1327c54)) * Use tree calculator in world state synchronizer ([#8902](https://github.com/AztecProtocol/aztec-packages/issues/8902)) ([2fd4be9](https://github.com/AztecProtocol/aztec-packages/commit/2fd4be918dd6be82c140250bb5b2479e201813b4)) ### Miscellaneous * Add comments to log oracles ([#8981](https://github.com/AztecProtocol/aztec-packages/issues/8981)) ([8efa7ac](https://github.com/AztecProtocol/aztec-packages/commit/8efa7ac9d30d84f76e61b5915e25d6b4619d46a9)) * Add memoize decorator ([#8976](https://github.com/AztecProtocol/aztec-packages/issues/8976)) ([1d9711b](https://github.com/AztecProtocol/aztec-packages/commit/1d9711b0a145f47bfe6d4d64b6837873e2725d2f)) * Archiver identifies prune ([#8666](https://github.com/AztecProtocol/aztec-packages/issues/8666)) ([4cf0f70](https://github.com/AztecProtocol/aztec-packages/commit/4cf0f70681d05e258bcc368e4f6b0880ab86dbe4)) * Autumn cleaning ([#8818](https://github.com/AztecProtocol/aztec-packages/issues/8818)) ([c1a9c6b](https://github.com/AztecProtocol/aztec-packages/commit/c1a9c6b05c1825a1d6276eaa398de4497b76f76f)) * **avm:** Make indirects big enough for relative addressing ([#9000](https://github.com/AztecProtocol/aztec-packages/issues/9000)) ([39b9e78](https://github.com/AztecProtocol/aztec-packages/commit/39b9e78d008b0a3d8be89f4bc6837ac4e3c28b4f)) * **avm:** Remove CMOV opcode ([#9030](https://github.com/AztecProtocol/aztec-packages/issues/9030)) ([ec9dfdf](https://github.com/AztecProtocol/aztec-packages/commit/ec9dfdf9ba36d9bb2e3829a8cdd5b0ed94cbc3fb)) * **avm:** Remove mem accounting from gas ([#8904](https://github.com/AztecProtocol/aztec-packages/issues/8904)) ([38b485e](https://github.com/AztecProtocol/aztec-packages/commit/38b485e4e8bf75453491d41a590f92afa25d4831)) * **bb.js:** Strip wasm-threads again ([#8833](https://github.com/AztecProtocol/aztec-packages/issues/8833)) ([68ba5d4](https://github.com/AztecProtocol/aztec-packages/commit/68ba5d443a79c06d972019abe39faaf851bb3247)) * Big synching case + stability ([#9022](https://github.com/AztecProtocol/aztec-packages/issues/9022)) ([931c59b](https://github.com/AztecProtocol/aztec-packages/commit/931c59b639577e755ccff0f9c9b9e2a3c88f558c)) * Bump foundry ([#8868](https://github.com/AztecProtocol/aztec-packages/issues/8868)) ([bfd0b8e](https://github.com/AztecProtocol/aztec-packages/commit/bfd0b8e6932c2b2fdf6e1c35c3c324edec92118a)) * **ci:** Another earthly corruption retry case ([#8799](https://github.com/AztecProtocol/aztec-packages/issues/8799)) ([c78b2cb](https://github.com/AztecProtocol/aztec-packages/commit/c78b2cb8d1d70c946a8ebeeed6c6618e98f9f542)) * **ci:** Finally isolate bb-native-tests ([#9039](https://github.com/AztecProtocol/aztec-packages/issues/9039)) ([9c9c385](https://github.com/AztecProtocol/aztec-packages/commit/9c9c385b2d8d3d8284d981a7393500a04fd78d38)) * **ci:** Increase timeout for ARM build ([#9041](https://github.com/AztecProtocol/aztec-packages/issues/9041)) ([c505b02](https://github.com/AztecProtocol/aztec-packages/commit/c505b02d10cdf52230b5af0e3c88642a8a3316e8)) * **ci:** Turn on S3 caching for all PRs ([#8898](https://github.com/AztecProtocol/aztec-packages/issues/8898)) ([c68a5ef](https://github.com/AztecProtocol/aztec-packages/commit/c68a5eff1f438860f2aa85d59c48ba9f85fc3d0d)) * **ci:** Update gates diff action to not post Brillig sizes report with no changes (https://github.com/noir-lang/noir/pull/6157) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Cleanup of `Aztec.nr` encryption code ([#8780](https://github.com/AztecProtocol/aztec-packages/issues/8780)) ([0bfcbba](https://github.com/AztecProtocol/aztec-packages/commit/0bfcbbaa74ae8a80d9586bd5049ec9fbe0480a7d)) * Delay proof quote collection ([#8967](https://github.com/AztecProtocol/aztec-packages/issues/8967)) ([640b661](https://github.com/AztecProtocol/aztec-packages/commit/640b66103eb111b5f2c5a4245a66559f9f5e0f84)) * **deploy:** Use docker run instead of helm test, metrics dashboard scripts ([#8926](https://github.com/AztecProtocol/aztec-packages/issues/8926)) ([797d0ca](https://github.com/AztecProtocol/aztec-packages/commit/797d0ca4abb396b6325a8159ca3be248c16c6b97)) * Deprecate various items in stdlib (https://github.com/noir-lang/noir/pull/6156) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Disable block building e2e ([#8895](https://github.com/AztecProtocol/aztec-packages/issues/8895)) ([ada6220](https://github.com/AztecProtocol/aztec-packages/commit/ada62205b127c61c2ca81ee74310d089ec560ccb)) * Disable e2e-fees-failure ([#8784](https://github.com/AztecProtocol/aztec-packages/issues/8784)) ([10b87d1](https://github.com/AztecProtocol/aztec-packages/commit/10b87d109e0b02f0b879df91456ffdc95d9a5fe6)) * Do not start prover node in e2e tests if not needed ([#9008](https://github.com/AztecProtocol/aztec-packages/issues/9008)) ([a2d3f8a](https://github.com/AztecProtocol/aztec-packages/commit/a2d3f8a2bf559b7a024e181a61ed3c1bbc6ff02b)) * **docs:** Add link to more info about proving backend to Solidity verifier page (https://github.com/noir-lang/noir/pull/5754) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Enable tests on aztec-nr and contracts (https://github.com/noir-lang/noir/pull/6162) ([6bd5b7e](https://github.com/AztecProtocol/aztec-packages/commit/6bd5b7e2491ed0b20f1ba1cf8f1b6b7504cca085)) * Event encryption funcs working as note ones ([#8819](https://github.com/AztecProtocol/aztec-packages/issues/8819)) ([77636f0](https://github.com/AztecProtocol/aztec-packages/commit/77636f053526a8690016f9a47b5a3f625aff5fcf)) * Final partial notes related cleanup ([#8987](https://github.com/AztecProtocol/aztec-packages/issues/8987)) ([880c45f](https://github.com/AztecProtocol/aztec-packages/commit/880c45f4a73e54c60ba8d887ae5f3515e6efd5ad)), closes [#8238](https://github.com/AztecProtocol/aztec-packages/issues/8238) * Fix flakey e2e fees failures test ([#8807](https://github.com/AztecProtocol/aztec-packages/issues/8807)) ([99bac95](https://github.com/AztecProtocol/aztec-packages/commit/99bac950f3c057ee1c25ea61fa6fe4834b348e24)) * Fix some more imports ([#8804](https://github.com/AztecProtocol/aztec-packages/issues/8804)) ([ffe70ec](https://github.com/AztecProtocol/aztec-packages/commit/ffe70ecac593a4b9e2cbb61bc9db4a280c6d917e)) * Fix the transfer test we run in kind clusters ([#8796](https://github.com/AztecProtocol/aztec-packages/issues/8796)) ([7c42ef0](https://github.com/AztecProtocol/aztec-packages/commit/7c42ef09bfc006c1d9725ac89e315d9a84c430fc)) * Fix typo in code snippet (https://github.com/noir-lang/noir/pull/6211) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Have prover-node self-mint L1 fee juice ([#9007](https://github.com/AztecProtocol/aztec-packages/issues/9007)) ([9f1e73a](https://github.com/AztecProtocol/aztec-packages/commit/9f1e73a3a1b746678215f04ea3f5496d6e90be97)) * Increase timeout of AVM full tests job to 75 minutes ([#8883](https://github.com/AztecProtocol/aztec-packages/issues/8883)) ([b70a728](https://github.com/AztecProtocol/aztec-packages/commit/b70a728a8adee13a6b572bb2594d933498bfb70c)) * Keccak_ultra -> ultra_keccak ([#8878](https://github.com/AztecProtocol/aztec-packages/issues/8878)) ([670af8a](https://github.com/AztecProtocol/aztec-packages/commit/670af8a158633d106a3f1df82dbd28ef9a9e4ceb)) * Minor archiver refactor ([#8715](https://github.com/AztecProtocol/aztec-packages/issues/8715)) ([b0d1bab](https://github.com/AztecProtocol/aztec-packages/commit/b0d1bab1f02819e7efbe0db73c3c805b5927b66a)) * Misc unsafe improvements ([#8803](https://github.com/AztecProtocol/aztec-packages/issues/8803)) ([cfe907c](https://github.com/AztecProtocol/aztec-packages/commit/cfe907cc3279a138c8db97b19f359740e0470f9b)) * Move governance out of core ([#8823](https://github.com/AztecProtocol/aztec-packages/issues/8823)) ([7411acc](https://github.com/AztecProtocol/aztec-packages/commit/7411acc0f79c4100d0311555bbcf6bacd072024f)) * Nuking `encode_and_encrypt_note(...)` ([#8815](https://github.com/AztecProtocol/aztec-packages/issues/8815)) ([2da9695](https://github.com/AztecProtocol/aztec-packages/commit/2da9695224e799abe317069af443f0b55ef2e007)) * Nuking `log_traits.nr` ([#8797](https://github.com/AztecProtocol/aztec-packages/issues/8797)) ([5d4accf](https://github.com/AztecProtocol/aztec-packages/commit/5d4accf47cdcd5e760616689c859a4d99824b530)) * Nuking encryption oracles ([#8817](https://github.com/AztecProtocol/aztec-packages/issues/8817)) ([8c98757](https://github.com/AztecProtocol/aztec-packages/commit/8c9875712e0b935947e753836148026fad7508fa)) * Nuking L2Block.fromFields ([#8882](https://github.com/AztecProtocol/aztec-packages/issues/8882)) ([b6551a9](https://github.com/AztecProtocol/aztec-packages/commit/b6551a96cabfb9c511fc60bb9aca2fe57afe7237)) * Optimise l1 to l2 message fetching ([#8672](https://github.com/AztecProtocol/aztec-packages/issues/8672)) ([7b1fb45](https://github.com/AztecProtocol/aztec-packages/commit/7b1fb457023fc60f55d6f9b91f513138082d98bd)) * Partial notes macros ([#8993](https://github.com/AztecProtocol/aztec-packages/issues/8993)) ([567e9a8](https://github.com/AztecProtocol/aztec-packages/commit/567e9a8ecc3666dc5140c3868b21f7a856a34f68)) * Protogalaxy only instantiated with Mega ([#8949](https://github.com/AztecProtocol/aztec-packages/issues/8949)) ([b8d87f1](https://github.com/AztecProtocol/aztec-packages/commit/b8d87f12224ac7e1c4e0bf0e353ddc902bf82fd4)) * Prove_then_verify_ultra_honk on all existing acir tests ([#9042](https://github.com/AztecProtocol/aztec-packages/issues/9042)) ([62f6b8a](https://github.com/AztecProtocol/aztec-packages/commit/62f6b8aeb92bfb266a0df647a0dd33cfdb021f5f)) * Publish bb.js in github action ([#8959](https://github.com/AztecProtocol/aztec-packages/issues/8959)) ([a21ab89](https://github.com/AztecProtocol/aztec-packages/commit/a21ab8915937b3c3f98551fb078c9874f2ed1547)) * Push proof splitting helpers into bb.js ([#8795](https://github.com/AztecProtocol/aztec-packages/issues/8795)) ([951ce6d](https://github.com/AztecProtocol/aztec-packages/commit/951ce6d974504f0453ad2816d10c358d8ef02ce5)) * Rebuild fixtures ([#8995](https://github.com/AztecProtocol/aztec-packages/issues/8995)) ([96b6cfc](https://github.com/AztecProtocol/aztec-packages/commit/96b6cfcc084da7a3012d2125daa067a33edfed16)) * Redo typo PR by bravesasha ([#9003](https://github.com/AztecProtocol/aztec-packages/issues/9003)) ([b516d3a](https://github.com/AztecProtocol/aztec-packages/commit/b516d3a07c53f431a0554657780343a25715409a)) * Redo typo PR by sfyll ([#9002](https://github.com/AztecProtocol/aztec-packages/issues/9002)) ([c970ced](https://github.com/AztecProtocol/aztec-packages/commit/c970ced462fff400afbbcafdcd9cb795891de339)) * Redo typo PR by skaunov ([#8933](https://github.com/AztecProtocol/aztec-packages/issues/8933)) ([7ef1643](https://github.com/AztecProtocol/aztec-packages/commit/7ef1643218356d22d09601269f346927694e22d7)) * Reduce number of gates in stdlib/sha256 hash function ([#8905](https://github.com/AztecProtocol/aztec-packages/issues/8905)) ([dd3a27e](https://github.com/AztecProtocol/aztec-packages/commit/dd3a27e5dc66fc47c34c077ca8124efe6fbea900)) * Reexport `CrateName` through `nargo` (https://github.com/noir-lang/noir/pull/6177) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * **refactor:** Array set optimization context struct for analysis (https://github.com/noir-lang/noir/pull/6204) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Release from Github Actions ([#8820](https://github.com/AztecProtocol/aztec-packages/issues/8820)) ([0354706](https://github.com/AztecProtocol/aztec-packages/commit/03547062bf79f1940275393d6e9080e92f83a768)) * Release Noir(0.35.0) (https://github.com/noir-lang/noir/pull/6030) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Remove `DefCollectorErrorKind::MacroError` (https://github.com/noir-lang/noir/pull/6174) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Remove copy from `compute_row_evaluations` ([#8875](https://github.com/AztecProtocol/aztec-packages/issues/8875)) ([9cd450e](https://github.com/AztecProtocol/aztec-packages/commit/9cd450e79870e00fb7c4c574a1e7f55de2e7b8ff)) * Remove macros_api module (https://github.com/noir-lang/noir/pull/6190) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Remove mock proof commitment escrow ([#9011](https://github.com/AztecProtocol/aztec-packages/issues/9011)) ([4873c7b](https://github.com/AztecProtocol/aztec-packages/commit/4873c7bc850092e2962fcaf747ec60f19e89ba92)) * Remove single block proving ([#8856](https://github.com/AztecProtocol/aztec-packages/issues/8856)) ([aadd9d5](https://github.com/AztecProtocol/aztec-packages/commit/aadd9d5029ace4097a7af51fdfcb5437737b28c5)) * Remove unused header in public executor ([#8990](https://github.com/AztecProtocol/aztec-packages/issues/8990)) ([8e35125](https://github.com/AztecProtocol/aztec-packages/commit/8e35125e45c8e882b388f70bc4c30208a9fbb866)) * Remove unused import ([#8835](https://github.com/AztecProtocol/aztec-packages/issues/8835)) ([dbf2c13](https://github.com/AztecProtocol/aztec-packages/commit/dbf2c13bdbfbe2957eb8a6e2716d9feab6e0ea6d)) * Remove unused methods and small state cleanup ([#8968](https://github.com/AztecProtocol/aztec-packages/issues/8968)) ([9b66a3e](https://github.com/AztecProtocol/aztec-packages/commit/9b66a3e3d1a38b31cdad29f9fd9aee05738b066c)) * Removing hack commitment from eccvm ([#8825](https://github.com/AztecProtocol/aztec-packages/issues/8825)) ([5e4cfa7](https://github.com/AztecProtocol/aztec-packages/commit/5e4cfa7b0159f66e59365f14c02fe8bbf4a73935)) * Rename `DefinitionKind::GenericType` (https://github.com/noir-lang/noir/pull/6182) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Replace relative paths to noir-protocol-circuits ([e062c5b](https://github.com/AztecProtocol/aztec-packages/commit/e062c5be333f6429e19fba92a8e97ba498936ab2)) * Replace relative paths to noir-protocol-circuits ([a0ce8cc](https://github.com/AztecProtocol/aztec-packages/commit/a0ce8cc923c3f7e431781990c5f3119777370254)) * Replace relative paths to noir-protocol-circuits ([240f408](https://github.com/AztecProtocol/aztec-packages/commit/240f408750da2ff6d8cb8095872d1869c78cc377)) * Replace relative paths to noir-protocol-circuits ([4589b79](https://github.com/AztecProtocol/aztec-packages/commit/4589b79b57711e015bbd0fb98e998048b04b3b63)) * Replace relative paths to noir-protocol-circuits ([42d4dde](https://github.com/AztecProtocol/aztec-packages/commit/42d4dde927a4ca9da556cdd7efd5d21d7900c70e)) * Replace relative paths to noir-protocol-circuits ([8cd9eee](https://github.com/AztecProtocol/aztec-packages/commit/8cd9eee5e72a1444170113ae5248c8334560c9d8)) * Replace relative paths to noir-protocol-circuits ([a79bbdd](https://github.com/AztecProtocol/aztec-packages/commit/a79bbdd9fef9f13d084fc875f520629439ba2407)) * Replace relative paths to noir-protocol-circuits ([fd693fe](https://github.com/AztecProtocol/aztec-packages/commit/fd693fee62486ff698e78cc6bb82aa11c2fa38af)) * Replace relative paths to noir-protocol-circuits ([c93bb8f](https://github.com/AztecProtocol/aztec-packages/commit/c93bb8f9ad1cc7f17d66ca9ff7298bb6d8ab6d44)) * Revert "feat: partial notes log encoding ([#8538](https://github.com/AztecProtocol/aztec-packages/issues/8538))" ([#8712](https://github.com/AztecProtocol/aztec-packages/issues/8712)) ([ef1a41e](https://github.com/AztecProtocol/aztec-packages/commit/ef1a41eb838b7bdb108b0218a5e51929bfcf8acc)) * Revert "fix: assign one_idx in the same place as zero_idx in `UltraCircuitBuilder`" ([#9049](https://github.com/AztecProtocol/aztec-packages/issues/9049)) ([ebb6a2d](https://github.com/AztecProtocol/aztec-packages/commit/ebb6a2da62c9d99f448b0da9cf1d14fd64a59b9f)) * Revert mistaken stack size change (https://github.com/noir-lang/noir/pull/6212) ([0d5b116](https://github.com/AztecProtocol/aztec-packages/commit/0d5b116bf988a018cf9da4fed36c283b254a9a2b)) * Set assume proven in e2e ([#8830](https://github.com/AztecProtocol/aztec-packages/issues/8830)) ([f4453ce](https://github.com/AztecProtocol/aztec-packages/commit/f4453cec8a4e8060950c35d26cb09330c03ec08c)) * Shared mutable slots use poseidon2 with separator ([#8919](https://github.com/AztecProtocol/aztec-packages/issues/8919)) ([36431d7](https://github.com/AztecProtocol/aztec-packages/commit/36431d78a811294856f011dbf37ac3b36bcdc3c2)) * Small cleanup ([#8965](https://github.com/AztecProtocol/aztec-packages/issues/8965)) ([8031ef4](https://github.com/AztecProtocol/aztec-packages/commit/8031ef45fc02f8897336729e7c41925ecae7c2e2)) * Spartan kubernetes documentation ([#9012](https://github.com/AztecProtocol/aztec-packages/issues/9012)) ([75efafc](https://github.com/AztecProtocol/aztec-packages/commit/75efafc9ff25c2ce2480547c97dc59fb87a168a5)) * Split `test_program`s into modules (https://github.com/noir-lang/noir/pull/6101) ([2e6340b](https://github.com/AztecProtocol/aztec-packages/commit/2e6340b09b46052d64bd2be239b0d512f59cdfb7)) * Untangled TS encryption functionality ([#8827](https://github.com/AztecProtocol/aztec-packages/issues/8827)) ([048a848](https://github.com/AztecProtocol/aztec-packages/commit/048a8480ea81d669f730cc604b5b85b2a3c84325)) * Update migration notes with version # ([#9045](https://github.com/AztecProtocol/aztec-packages/issues/9045)) ([02a0bc1](https://github.com/AztecProtocol/aztec-packages/commit/02a0bc1449202a7dbe9ad5d6fea7b6e1a4025e4f)) * Use Noir implementation of pedersen in public (uses MSM instead of pedersen BBs) ([#8798](https://github.com/AztecProtocol/aztec-packages/issues/8798)) ([02821d0](https://github.com/AztecProtocol/aztec-packages/commit/02821d0fb3000537aa8001a00d93c74af3003cc2)) * Use require(predicate, custom_error) ([#8859](https://github.com/AztecProtocol/aztec-packages/issues/8859)) ([84e5e0c](https://github.com/AztecProtocol/aztec-packages/commit/84e5e0ccda7766d205803ca35e0a307a262a96b5)) </details> <details><summary>barretenberg: 0.57.0</summary> ## [0.57.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg-v0.56.0...barretenberg-v0.57.0) (2024-10-07) ### ⚠ BREAKING CHANGES * **avm:** remove CMOV opcode ([#9030](https://github.com/AztecProtocol/aztec-packages/issues/9030)) * **avm:** make indirects big enough for relative addressing ([#9000](https://github.com/AztecProtocol/aztec-packages/issues/9000)) * keccak_ultra -> ultra_keccak ([#8878](https://github.com/AztecProtocol/aztec-packages/issues/8878)) ### Features * Add support for unlimited width in ACIR ([#8960](https://github.com/AztecProtocol/aztec-packages/issues/8960)) ([3e05e22](https://github.com/AztecProtocol/aztec-packages/commit/3e05e22d8d9fc73c1225570342392dda5661403f)) * **avm:** Integrate public inputs in AVM recursive verifier ([#8846](https://github.com/AztecProtocol/aztec-packages/issues/8846)) ([4354ae0](https://github.com/AztecProtocol/aztec-packages/commit/4354ae030b5b7e365ff0361e88cd74cd95d71e04)), closes [#8714](https://github.com/AztecProtocol/aztec-packages/issues/8714) * **avm:** Skip gas accounting for fake rows ([#8944](https://github.com/AztecProtocol/aztec-packages/issues/8944)) ([818325a](https://github.com/AztecProtocol/aztec-packages/commit/818325ae35ce0260d88e097261d173f4dc326cbe)), closes [#8903](https://github.com/AztecProtocol/aztec-packages/issues/8903) * CI/local S3 build cache ([#8802](https://github.com/AztecProtocol/aztec-packages/issues/8802)) ([06be26e](https://github.com/AztecProtocol/aztec-packages/commit/06be26e2b5dfd4b1fa35f57231e15ebffbe410a7)) * Connect the public inputs but not the proof in ivc recursion constraints ([#8973](https://github.com/AztecProtocol/aztec-packages/issues/8973)) ([4f1af9a](https://github.com/AztecProtocol/aztec-packages/commit/4f1af9a0baf9e342d0de41ebd58fed24a0c4f615)) * Faster CIV benching with mocked VKs ([#8843](https://github.com/AztecProtocol/aztec-packages/issues/8843)) ([fad3d6e](https://github.com/AztecProtocol/aztec-packages/commit/fad3d6e41765c774696ecc98d45a27851c7c4442)) * Handle consecutive kernels in IVC ([#8924](https://github.com/AztecProtocol/aztec-packages/issues/8924)) ([0be9f25](https://github.com/AztecProtocol/aztec-packages/commit/0be9f253238cc1453d07385ece565f946d4212a3)) * Lazy commitment key allocation for better memory ([#9017](https://github.com/AztecProtocol/aztec-packages/issues/9017)) ([527d820](https://github.com/AztecProtocol/aztec-packages/commit/527d820fcadc24105e43b819da1ad9d848b755ca)) * Make shplemini proof constant ([#8826](https://github.com/AztecProtocol/aztec-packages/issues/8826)) ([c8cbc33](https://github.com/AztecProtocol/aztec-packages/commit/c8cbc3388c2bbe9a0ba8a95717e1b71c602d58e3)) * New Tracy Time preset and more efficient univariate extension ([#8789](https://github.com/AztecProtocol/aztec-packages/issues/8789)) ([ead4649](https://github.com/AztecProtocol/aztec-packages/commit/ead4649b0c21a98534c36e7755edac68052b3c26)) * Origin Tags part 1 ([#8787](https://github.com/AztecProtocol/aztec-packages/issues/8787)) ([ed1e23e](https://github.com/AztecProtocol/aztec-packages/commit/ed1e23edff04ea026a94ffc22b29b6ef520cdf55)) * Origin Tags Part 2 ([#8936](https://github.com/AztecProtocol/aztec-packages/issues/8936)) ([77c05f5](https://github.com/AztecProtocol/aztec-packages/commit/77c05f5469bad85e1394c05e1878791bac084559)) * **sol:** Add shplemini transcript ([#8865](https://github.com/AztecProtocol/aztec-packages/issues/8865)) ([089dbad](https://github.com/AztecProtocol/aztec-packages/commit/089dbadd9e9ca304004c38e01d3703d923b257ec)) * **sol:** Shplemini verification ([#8866](https://github.com/AztecProtocol/aztec-packages/issues/8866)) ([989eb08](https://github.com/AztecProtocol/aztec-packages/commit/989eb08256db49e65e2d5e8a91790f941761d08f)) * Ultra honk on Shplemini ([#8886](https://github.com/AztecProtocol/aztec-packages/issues/8886)) ([d8d04f6](https://github.com/AztecProtocol/aztec-packages/commit/d8d04f6f0b9ca0aa36008dc53dde2562dc3afa63)) * Use structured polys to reduce prover memory ([#8587](https://github.com/AztecProtocol/aztec-packages/issues/8587)) ([59e3dd9](https://github.com/AztecProtocol/aztec-packages/commit/59e3dd93a70398e828269dbf13d8c4b9b38227ea)) ### Bug Fixes * Assign one_idx in the same place as zero_idx in `UltraCircuitBuilder` ([#9029](https://github.com/AztecProtocol/aztec-packages/issues/9029)) ([fe11d9a](https://github.com/AztecProtocol/aztec-packages/commit/fe11d9a3a1b96454999ae627c902d8b362805172)) * **avm:** Kernel out full proving fix ([#8873](https://github.com/AztecProtocol/aztec-packages/issues/8873)) ([784d483](https://github.com/AztecProtocol/aztec-packages/commit/784d483b592cb80da143634c07d330ba2f2c9ab7)) * Bb.js acir tests ([#8862](https://github.com/AztecProtocol/aztec-packages/issues/8862)) ([d8d0541](https://github.com/AztecProtocol/aztec-packages/commit/d8d0541bde1d98d6b7ae3c3bb2a38068383f802b)) ### Miscellaneous * **avm:** Make indirects big enough for relative addressing ([#9000](https://github.com/AztecProtocol/aztec-packages/issues/9000)) ([39b9e78](https://github.com/AztecProtocol/aztec-packages/commit/39b9e78d008b0a3d8be89f4bc6837ac4e3c28b4f)) * **avm:** Remove CMOV opcode ([#9030](https://github.com/AztecProtocol/aztec-packages/issues/9030)) ([ec9dfdf](https://github.com/AztecProtocol/aztec-packages/commit/ec9dfdf9ba36d9bb2e3829a8cdd5b0ed94cbc3fb)) * **bb.js:** Strip wasm-threads again ([#8833](https://github.com/AztecProtocol/aztec-packages/issues/8833)) ([68ba5d4](https://github.com/AztecProtocol/aztec-packages/commit/68ba5d443a79c06d972019abe39faaf851bb3247)) * Bump foundry ([#8868](https://github.com/AztecProtocol/aztec-packages/issues/8868)) ([bfd0b8e](https://github.com/AztecProtocol/aztec-packages/commit/bfd0b8e6932c2b2fdf6e1c35c3c324edec92118a)) * **ci:** Finally isolate bb-native-tests ([#9039](https://github.com/AztecProtocol/aztec-packages/issues/9039)) ([9c9c385](https://github.com/AztecProtocol/aztec-packages/commit/9c9c385b2d8d3d8284d981a7393500a04fd78d38)) * Keccak_ultra -> ultra_keccak ([#8878](https://github.com/AztecProtocol/aztec-packages/issues/8878)) ([670af8a](https://github.com/AztecProtocol/aztec-packages/commit/670af8a158633d106a3f1df82dbd28ef9a9e4ceb)) * Protogalaxy only instantiated with Mega ([#8949](https://github.com/AztecProtocol/aztec-packages/issues/8949)) ([b8d87f1](https://github.com/AztecProtocol/aztec-packages/commit/b8d87f12224ac7e1c4e0bf0e353ddc902bf82fd4)) * Prove_then_verify_ultra_honk on all existing acir tests ([#9042](https://github.com/AztecProtocol/aztec-packages/issues/9042)) ([62f6b8a](https://github.com/AztecProtocol/aztec-packages/commit/62f6b8aeb92bfb266a0df647a0dd33cfdb021f5f)) * Reduce number of gates in stdlib/sha256 hash function ([#8905](https://github.com/AztecProtocol/aztec-packages/issues/8905)) ([dd3a27e](https://github.com/AztecProtocol/aztec-packages/commit/dd3a27e5dc66fc47c34c077ca8124efe6fbea900)) * Remove copy from `compute_row_evaluations` ([#8875](https://github.com/AztecProtocol/aztec-packages/issues/8875)) ([9cd450e](https://github.com/AztecProtocol/aztec-packages/commit/9cd450e79870e00fb7c4c574a1e7f55de2e7b8ff)) * Remove unused methods and small state cleanup ([#8968](https://github.com/AztecProtocol/aztec-packages/issues/8968)) ([9b66a3e](https://github.com/AztecProtocol/aztec-packages/commit/9b66a3e3d1a38b31cdad29f9fd9aee05738b066c)) * Removing hack commitment from eccvm ([#8825](https://github.com/AztecProtocol/aztec-packages/issues/8825)) ([5e4cfa7](https://github.com/AztecProtocol/aztec-packages/commit/5e4cfa7b0159f66e59365f14c02fe8bbf4a73935)) * Revert "fix: assign one_idx in the same place as zero_idx in `UltraCircuitBuilder`" ([#9049](https://github.com/AztecProtocol/aztec-packages/issues/9049)) ([ebb6a2d](https://github.com/AztecProtocol/aztec-packages/commit/ebb6a2da62c9d99f448b0da9cf1d14fd64a59b9f)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

# Description ## Problem Part of #4515 Apparently in #6179 I only made it work for calls like `foo::Bar::baz()` but no checks were done for method calls (where `self` is involved). ## Summary This PR now warns when calling private or `pub(crate)` methods, either on structs or primitive types, when they are not accessible from the current module. We also now don't suggest non-accessible methods from LSP. ## Additional Context I also removed an unused global that was introduced some time ago. ## Documentation Check one: - [x] No documentation needed. - [ ] Documentation included in this PR. - [ ] **[For Experimental Features]** Documentation to be submitted in a separate PR. # PR Checklist - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.

🤖 I have created a release *beep* *boop* --- <details><summary>0.36.0</summary> ## [0.36.0](v0.35.0...v0.36.0) (2024-10-22) ### ⚠ BREAKING CHANGES * remove pedersen commitment (AztecProtocol/aztec-packages#9107) * remove pedersen hash opcode (AztecProtocol/aztec-packages#9245) * Brillig and AVM default all uninitialized memory cells to Field 0 (AztecProtocol/aztec-packages#9057) * remove keccak256 opcode from ACIR/Brillig (AztecProtocol/aztec-packages#9104) * Brillig with a stack and conditional inlining (AztecProtocol/aztec-packages#8989) * **avm:** remove CMOV opcode (AztecProtocol/aztec-packages#9030) * Integer division is not the inverse of integer multiplication ([#6243](#6243)) * kind size checks ([#6137](#6137)) * Change tag attributes to require a ' prefix ([#6235](#6235)) ### Features * Add `checked_transmute` ([#6262](#6262)) ([2618061](2618061)) * Add more `Type` and `UnresolvedType` methods ([#5994](#5994)) ([8236cbd](8236cbd)) * Allow `unconstrained` after visibility ([#6246](#6246)) ([f6dfbcf](f6dfbcf)) * Brillig and AVM default all uninitialized memory cells to Field 0 (AztecProtocol/aztec-packages#9057) ([70dcf4a](70dcf4a)) * Brillig with a stack and conditional inlining (AztecProtocol/aztec-packages#8989) ([70dcf4a](70dcf4a)) * Don't crash LSP when there are errors resolving the workspace ([#6257](#6257)) ([7cc7197](7cc7197)) * Don't suggest private struct fields in LSP ([#6256](#6256)) ([2a727b3](2a727b3)) * Handwritten parser ([#6180](#6180)) ([c4273a0](c4273a0)) * **improve:** Remove scan through globals ([#6282](#6282)) ([fd91913](fd91913)) * Inclusive for loop ([#6200](#6200)) ([bd861f2](bd861f2)) * Integrate databus in the private kernels (AztecProtocol/aztec-packages#9028) ([70dcf4a](70dcf4a)) * **interpreter:** Comptime derive generators ([#6303](#6303)) ([d8767b3](d8767b3)) * Kind size checks ([#6137](#6137)) ([6e40f62](6e40f62)) * New formatter ([#6300](#6300)) ([62404d7](62404d7)) * Optimize `Quoted::as_expr` by parsing just once ([#6237](#6237)) ([a4fcd00](a4fcd00)) * Optimize reading a workspace's files ([#6281](#6281)) ([b54ed26](b54ed26)) * **perf:** Flamegraphs for test program execution benchmarks ([#6253](#6253)) ([c186791](c186791)) * **perf:** Follow array sets backwards in array set from get optimization ([#6208](#6208)) ([999071b](999071b)) * Recover from '=' instead of ':' in struct constructor/pattern ([#6236](#6236)) ([9a12f31](9a12f31)) * Remove byte decomposition in `compute_decomposition` ([#6159](#6159)) ([a8bcae2](a8bcae2)) * Show LSP diagnostic related information ([#6277](#6277)) ([c8a91a5](c8a91a5)) * Slightly improve "unexpected token" error message ([#6279](#6279)) ([8232bfa](8232bfa)) * Sync from noir (AztecProtocol/aztec-packages#8934) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9034) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9099) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9275) ([70dcf4a](70dcf4a)) * **test:** Fuzz poseidon hases against an external library ([#6273](#6273)) ([8d8ea89](8d8ea89)) * **test:** Fuzz test poseidon2 hash equivalence ([#6265](#6265)) ([f61ba03](f61ba03)) * **test:** Fuzz test stdlib hash functions ([#6233](#6233)) ([1a2ca46](1a2ca46)) * **test:** Include the PoseidonHasher in the fuzzing ([#6280](#6280)) ([afb8a7c](afb8a7c)) * Trait inheritance ([#6252](#6252)) ([d3301a4](d3301a4)) * Visibility for impl functions ([#6179](#6179)) ([1b26440](1b26440)) * Visibility for struct fields ([#6221](#6221)) ([fc1c7ab](fc1c7ab)) * Warn about private types leaking in public functions and struct fields ([#6296](#6296)) ([67ac0d6](67ac0d6)) ### Bug Fixes * Add missing visibility for auto-import names ([#6205](#6205)) ([c3cb38a](c3cb38a)) * Address inactive public key check in `verify_signature_noir` ([#6270](#6270)) ([e4325aa](e4325aa)) * Allow array map on empty arrays ([#6305](#6305)) ([51ae1b3](51ae1b3)) * Change tag attributes to require a ' prefix ([#6235](#6235)) ([b43dcb2](b43dcb2)) * Check for Schnorr null signature ([#6226](#6226)) ([2430920](2430920)) * Display function name and body when inlining recursion limit hit ([#6291](#6291)) ([33a1e7d](33a1e7d)) * Do not warn on unused self in traits ([#6298](#6298)) ([4d524bf](4d524bf)) * Don't warn on unuse global if it has an abi annotation ([#6258](#6258)) ([e13f617](e13f617)) * Don't warn on unused struct that has an abi annotation ([#6254](#6254)) ([8a31632](8a31632)) * Don't warn twice when referring to private item ([#6216](#6216)) ([619c545](619c545)) * Enforce correctness of decompositions performed at compile time ([#6278](#6278)) ([53252fd](53252fd)) * **frontend:** Do not warn when a nested struct is provided as input to main ([#6239](#6239)) ([9dfe223](9dfe223)) * Handle dfg databus in SSA normalization ([#6249](#6249)) ([9d8bee5](9d8bee5)) * Handle nested arrays in calldata ([#6232](#6232)) ([0ab8f5e](0ab8f5e)) * Homogeneous input points for EC ADD ([#6241](#6241)) ([f6a7306](f6a7306)) * Integer division is not the inverse of integer multiplication ([#6243](#6243)) ([1cd2587](1cd2587)) * Panic on composite types within databus ([#6225](#6225)) ([29bd125](29bd125)) * Prevent compiler panic when popping from empty slices ([#6274](#6274)) ([87137d8](87137d8)) * Reject invalid expression with in CLI parser ([#6287](#6287)) ([052aee8](052aee8)) * Remove need for duplicate attributes on each function (AztecProtocol/aztec-packages#9244) ([70dcf4a](70dcf4a)) * Visibility for impl methods ([#6261](#6261)) ([70cbeb4](70cbeb4)) ### Miscellaneous Chores * Remove keccak256 opcode from ACIR/Brillig (AztecProtocol/aztec-packages#9104) ([70dcf4a](70dcf4a)) * Remove pedersen commitment (AztecProtocol/aztec-packages#9107) ([70dcf4a](70dcf4a)) * Remove pedersen hash opcode (AztecProtocol/aztec-packages#9245) ([70dcf4a](70dcf4a)) ### Code Refactoring * **avm:** Remove CMOV opcode (AztecProtocol/aztec-packages#9030) ([70dcf4a](70dcf4a)) </details> <details><summary>0.52.0</summary> ## [0.52.0](v0.51.0...v0.52.0) (2024-10-22) ### ⚠ BREAKING CHANGES * remove pedersen commitment (AztecProtocol/aztec-packages#9107) * remove pedersen hash opcode (AztecProtocol/aztec-packages#9245) * Brillig and AVM default all uninitialized memory cells to Field 0 (AztecProtocol/aztec-packages#9057) * remove keccak256 opcode from ACIR/Brillig (AztecProtocol/aztec-packages#9104) * Brillig with a stack and conditional inlining (AztecProtocol/aztec-packages#8989) * **avm:** remove CMOV opcode (AztecProtocol/aztec-packages#9030) * remove sha256 opcode (AztecProtocol/aztec-packages#4571) * add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) * Add Not instruction in brillig (AztecProtocol/aztec-packages#8488) * **avm:** variants for SET opcode (AztecProtocol/aztec-packages#8441) * **avm/brillig:** take addresses in calldatacopy (AztecProtocol/aztec-packages#8388) * constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ### Features * (bb) 128-bit challenges (AztecProtocol/aztec-packages#8406) ([3c3ed1e](3c3ed1e)) * **acir_gen:** Width aware ACIR gen addition ([#5493](#5493)) ([85fa592](85fa592)) * Add assertions for ACVM `FunctionInput` `bit_size` ([#5864](#5864)) ([8712f4c](8712f4c)) * Add Not instruction in brillig (AztecProtocol/aztec-packages#8488) ([95e19ab](95e19ab)) * Add recursive aggregation object to proving/verification keys (AztecProtocol/aztec-packages#6770) ([4ea25db](4ea25db)) * Add reusable procedures to brillig generation (AztecProtocol/aztec-packages#7981) ([5c4f19f](5c4f19f)) * Add support for u1 in the avm, ToRadix's radix arg is a memory addr (AztecProtocol/aztec-packages#8570) ([e8bbce7](e8bbce7)) * Added indirect const instruction (AztecProtocol/aztec-packages#8065) ([5c4f19f](5c4f19f)) * Adding aggregation to honk and rollup (AztecProtocol/aztec-packages#7466) ([4ea25db](4ea25db)) * Automate verify_honk_proof input generation (AztecProtocol/aztec-packages#8092) ([5c4f19f](5c4f19f)) * **avm/brillig:** Take addresses in calldatacopy (AztecProtocol/aztec-packages#8388) ([3c3ed1e](3c3ed1e)) * **avm:** Variants for SET opcode (AztecProtocol/aztec-packages#8441) ([3c3ed1e](3c3ed1e)) * Avoid heap allocs when going to/from field (AztecProtocol/aztec-packages#7547) ([daad75c](daad75c)) * Brillig and AVM default all uninitialized memory cells to Field 0 (AztecProtocol/aztec-packages#9057) ([70dcf4a](70dcf4a)) * Brillig with a stack and conditional inlining (AztecProtocol/aztec-packages#8989) ([70dcf4a](70dcf4a)) * Change the layout of arrays and vectors to be a single pointer (AztecProtocol/aztec-packages#8448) ([d4832ec](d4832ec)) * Constant inputs for blackbox (AztecProtocol/aztec-packages#7222) ([fb97bb9](fb97bb9)) * Hook up secondary calldata column in dsl (AztecProtocol/aztec-packages#7759) ([4ea25db](4ea25db)) * Integrate databus in the private kernels (AztecProtocol/aztec-packages#9028) ([70dcf4a](70dcf4a)) * Integrate new proving systems in e2e (AztecProtocol/aztec-packages#6971) ([daad75c](daad75c)) * Make Brillig do integer arithmetic operations using u128 instead of Bigint (AztecProtocol/aztec-packages#7518) ([daad75c](daad75c)) * Make token transfer be recursive (AztecProtocol/aztec-packages#7730) ([4ea25db](4ea25db)) * New test programs for wasm benchmarking (AztecProtocol/aztec-packages#8389) ([95e19ab](95e19ab)) * Note hashes as points (AztecProtocol/aztec-packages#7618) ([4ea25db](4ea25db)) * Optimize allocating immediate amounts of memory (AztecProtocol/aztec-packages#8579) ([e8bbce7](e8bbce7)) * Optimize constant array handling in brillig_gen (AztecProtocol/aztec-packages#7661) ([4ea25db](4ea25db)) * Optimize to_radix (AztecProtocol/aztec-packages#8073) ([5c4f19f](5c4f19f)) * Pass calldata ids to the backend (AztecProtocol/aztec-packages#7875) ([4ea25db](4ea25db)) * Poseidon2 gates for Ultra arithmetisation (AztecProtocol/aztec-packages#7494) ([5c4f19f](5c4f19f)) * **profiler:** Add support for brillig functions in opcodes-flamegraph (AztecProtocol/aztec-packages#7698) ([4ea25db](4ea25db)) * Remove sha256 opcode (AztecProtocol/aztec-packages#4571) ([e8bbce7](e8bbce7)) * Removing superfluous call to MSM (AztecProtocol/aztec-packages#7708) ([4ea25db](4ea25db)) * Report gates and VKs of private protocol circuits with megahonk (AztecProtocol/aztec-packages#7722) ([4ea25db](4ea25db)) * Simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` ([#5140](#5140)) ([2823ba7](2823ba7)) * Small optimization in toradix (AztecProtocol/aztec-packages#8040) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#7392) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7400) ([fb97bb9](fb97bb9)) * Sync from noir (AztecProtocol/aztec-packages#7432) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7444) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7454) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7512) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7577) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7583) ([daad75c](daad75c)) * Sync from noir (AztecProtocol/aztec-packages#7743) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7862) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7945) ([4ea25db](4ea25db)) * Sync from noir (AztecProtocol/aztec-packages#7958) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8008) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8093) ([5c4f19f](5c4f19f)) * Sync from noir (AztecProtocol/aztec-packages#8125) ([f0c2686](f0c2686)) * Sync from noir (AztecProtocol/aztec-packages#8237) ([f0c2686](f0c2686)) * Sync from noir (AztecProtocol/aztec-packages#8423) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8435) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8466) ([3c3ed1e](3c3ed1e)) * Sync from noir (AztecProtocol/aztec-packages#8482) ([d4832ec](d4832ec)) * Sync from noir (AztecProtocol/aztec-packages#8512) ([95e19ab](95e19ab)) * Sync from noir (AztecProtocol/aztec-packages#8526) ([95e19ab](95e19ab)) * Sync from noir (AztecProtocol/aztec-packages#8934) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9034) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9099) ([70dcf4a](70dcf4a)) * Sync from noir (AztecProtocol/aztec-packages#9275) ([70dcf4a](70dcf4a)) * **test:** Fuzz test poseidon2 hash equivalence ([#6265](#6265)) ([f61ba03](f61ba03)) * **test:** Fuzz test stdlib hash functions ([#6233](#6233)) ([1a2ca46](1a2ca46)) * TXE nr deployments, dependency cleanup for CLI (AztecProtocol/aztec-packages#7548) ([4ea25db](4ea25db)) * Typing return values of embedded_curve_ops (AztecProtocol/aztec-packages#7413) ([daad75c](daad75c)) * Unify all acir recursion constraints based on RecursionConstraint and proof_type (AztecProtocol/aztec-packages#7993) ([5c4f19f](5c4f19f)) ### Bug Fixes * Add trailing extra arguments for backend in gates_flamegraph (AztecProtocol/aztec-packages#7472) ([daad75c](daad75c)) * **debugger:** Update the debugger to handle the new Brillig debug metadata format ([#5706](#5706)) ([a31f82e](a31f82e)) * Deflatten databus visibilities (AztecProtocol/aztec-packages#7761) ([4ea25db](4ea25db)) * Do not duplicate redundant Brillig debug metadata ([#5696](#5696)) ([e4f7dbe](e4f7dbe)) * Export brillig names in contract functions (AztecProtocol/aztec-packages#8212) ([f0c2686](f0c2686)) * Handle multiple entry points for Brillig call stack resolution after metadata deduplication ([#5788](#5788)) ([38fe9dd](38fe9dd)) * Homogeneous input points for EC ADD ([#6241](#6241)) ([f6a7306](f6a7306)) * Move BigInt modulus checks to runtime in brillig ([#5374](#5374)) ([741d339](741d339)) * Reject invalid expression with in CLI parser ([#6287](#6287)) ([052aee8](052aee8)) * Remove need for duplicate attributes on each function (AztecProtocol/aztec-packages#9244) ([70dcf4a](70dcf4a)) * Restrict keccak256_injective test input to 8 bits ([#5977](#5977)) ([a1b1346](a1b1346)) * Revert "feat: Sync from noir (AztecProtocol/aztec-packages#7512)" (AztecProtocol/aztec-packages#7558) ([daad75c](daad75c)) ### Miscellaneous Chores * Remove keccak256 opcode from ACIR/Brillig (AztecProtocol/aztec-packages#9104) ([70dcf4a](70dcf4a)) * Remove pedersen commitment (AztecProtocol/aztec-packages#9107) ([70dcf4a](70dcf4a)) * Remove pedersen hash opcode (AztecProtocol/aztec-packages#9245) ([70dcf4a](70dcf4a)) ### Code Refactoring * **avm:** Remove CMOV opcode (AztecProtocol/aztec-packages#9030) ([70dcf4a](70dcf4a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

feat: visibility for impl functions

12a1c6f

asterite requested a review from a team September 30, 2024 19:28

Merge branch 'master' into ab/visibility-for-impl-functions

842c915

asterite added 3 commits October 1, 2024 15:22

Don't error if calling struct private fn from same struct

3223b5b

Fix tests

50999da

Pass module ID instead of having to clone type

d69e224

chore: add new test case

d576a20

asterite added 3 commits October 2, 2024 10:51

Make sure a module can call private functions of its structs

385f5a6

Merge branch 'ab/visibility-for-impl-functions' of github.com:noir-la…

99e1a50

…ng/noir into ab/visibility-for-impl-functions

Fix test

6eeee56

Add/remove pub

29ffae4

TomAFrench approved these changes Oct 3, 2024

View reviewed changes

noir_stdlib/src/embedded_curve_ops.nr Outdated Show resolved Hide resolved

Remove one pub

bdd3447

asterite enabled auto-merge October 3, 2024 12:07

Make it pub(crate)

2b6aec2

asterite added this pull request to the merge queue Oct 3, 2024

Merged via the queue into master with commit 1b26440 Oct 3, 2024
47 checks passed

asterite deleted the ab/visibility-for-impl-functions branch October 3, 2024 13:22

noirwhal mentioned this pull request Oct 3, 2024

chore: Release Noir(0.36.0) #6213

Merged

AztecBot mentioned this pull request Oct 3, 2024

feat: Sync from noir AztecProtocol/aztec-packages#8934

Merged

AztecBot mentioned this pull request Oct 4, 2024

chore(master): Release 0.57.0 AztecProtocol/aztec-packages#8788

Merged

asterite mentioned this pull request Oct 9, 2024

fix: visibility for impl methods #6261

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: visibility for impl functions #6179

feat: visibility for impl functions #6179

asterite commented Sep 30, 2024 •

edited

Loading

TomAFrench commented Oct 1, 2024

asterite commented Oct 1, 2024

asterite commented Oct 1, 2024

TomAFrench commented Oct 2, 2024

asterite commented Oct 2, 2024

asterite commented Oct 2, 2024

TomAFrench commented Oct 2, 2024

asterite commented Oct 3, 2024

TomAFrench left a comment

feat: visibility for impl functions #6179

feat: visibility for impl functions #6179

Conversation

asterite commented Sep 30, 2024 • edited Loading

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

TomAFrench commented Oct 1, 2024

asterite commented Oct 1, 2024

asterite commented Oct 1, 2024

TomAFrench commented Oct 2, 2024

asterite commented Oct 2, 2024

asterite commented Oct 2, 2024

TomAFrench commented Oct 2, 2024

asterite commented Oct 3, 2024

TomAFrench left a comment

Choose a reason for hiding this comment

asterite commented Sep 30, 2024 •

edited

Loading