fix: don't deduplicate binary math of unsigned types

compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs

@@ -745,15 +745,17 @@ impl ResultCache {
         has_side_effects: bool,
     ) -> Option<CacheResult> {
         self.result.as_ref().and_then(|(origin_block, results)| {
+            if has_side_effects {
+                return None
+            }
+
             if dom.dominates(*origin_block, block) {
                 Some(CacheResult::Cached(results))
-            } else if !has_side_effects {
+            } else {
                 // Insert a copy of this instruction in the common dominator
                 let dominator = dom.common_dominator(*origin_block, block);
                 Some(CacheResult::NeedToHoistToCommonBlock(dominator))
-            } else {
-                None
-            }
+            } 
         })
     }
 }

test_programs/execution_success/regression_6834/Nargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "regression_6834"
+version = "0.1.0"
+type = "bin"
+authors = [""]
+
+[dependencies]

test_programs/execution_success/regression_6834/Prover.toml

@@ -0,0 +1,2 @@
+year = 2000
+min_age = 20

test_programs/execution_success/regression_6834/src/main.nr

@@ -0,0 +1,13 @@
+fn main(year: u32, min_age: u8) {
+    if min_age == 0 {
+        if year > 2028 {
+            assert((((year - 1) - 2028) / 4 + 1) as i32 >= 0);
+        }
+    } else {
+        if year > 2028 {
+            // Uncomment the next line and the assertion on line 10 will pass
+            // assert(year > 2028);
+            assert((((year - 1) - 2028) / 4 + 1) as i32 >= 0);
+        }
+    }
+}