Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Avoid reporting errors if labeler action fails #746

Merged
merged 1 commit into from
Feb 3, 2023
Merged

chore(ci): Avoid reporting errors if labeler action fails #746

merged 1 commit into from
Feb 3, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Feb 3, 2023

Related issue(s)

Resolves #

Description

We continue-on-error because the action is buggy and tries to remove labels when they don't exist.

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@phated phated requested a review from kevaundray February 3, 2023 21:58
@phated
Copy link
Contributor Author

phated commented Feb 3, 2023

The action still failed in this PR because we use pull_request_target which uses the action's yml file from master instead of the branch.

@phated phated requested a review from jfecher February 3, 2023 22:00
jfecher
jfecher approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good quick fix for now

@phated phated merged commit 2da75a8 into master Feb 3, 2023
@phated phated deleted the phated/skip-labeler-error branch February 3, 2023 22:13
TomAFrench added a commit that referenced this pull request Feb 3, 2023
@TomAFrench
Merge branch 'master' into nargo-execute
9756672 
* master:
  chore(nargo): add InputMap and WitnessMap terminology (#713)
  chore(ci): Avoid reporting errors if labeler action fails (#746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@kevaundray kevaundray Awaiting requested review from kevaundray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phated @jfecher