Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa): Remove values from array type #771

Merged
merged 8 commits into from
Feb 14, 2023
Merged

chore(ssa): Remove values from array type #771

merged 8 commits into from
Feb 14, 2023

Conversation

guipublic
Copy link
Contributor

Description

Summary of changes

This is a second step for supporting dynamic arrays. I removed the special handling that was done with arrays coming from the ABI. Instead they are initialised with store instructions so that they can be handled like any other array.

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

@guipublic guipublic requested a review from jfecher February 8, 2023 17:44
jfecher
jfecher reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One small style issue. I'm a fan of removing special casing in general, so treating abi arrays the same as other arrays is a plus for me.

crates/noirc_evaluator/src/ssa/code_gen.rs Outdated Show resolved Hide resolved
@kevaundray
Copy link
Contributor

Linking relevant issue: #766

@kevaundray kevaundray changed the title chor(ssa) Remove values from array type chore(ssa): Remove values from array type Feb 9, 2023
@kevaundray kevaundray requested a review from jfecher February 13, 2023 14:18
kevaundray
kevaundray previously approved these changes Feb 14, 2023
View reviewed changes
@kevaundray
Copy link
Contributor

LGTM , pending merge conflicts

@kevaundray kevaundray enabled auto-merge February 14, 2023 14:10
@kevaundray kevaundray added this pull request to the merge queue Feb 14, 2023
Merged via the queue into master with commit ad5d889 Feb 14, 2023
@kevaundray kevaundray deleted the gd/dynamic_array2 branch February 14, 2023 15:12
TomAFrench added a commit that referenced this pull request Feb 15, 2023
@TomAFrench
Merge branch 'master' into abi-to-witness-map
9630143 
* master:
  chore(ssa): Predicate for store instruction (#829)
  feat(std_lib): println statements (#630)
  chore(ci): Make Kev the committer on release lockfile updates (#845)
  feat(stdlib): Add higher order array functions (#833)
  chore(ssa): Remove values from array type (#771)
@kevaundray kevaundray mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher left review comments

@kevaundray kevaundray kevaundray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guipublic @kevaundray @jfecher