New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ssa): per array memory map #832

Merged

guipublic merged 5 commits into master from gd/dynamic_array4

Feb 14, 2023

Contributor

guipublic commented Feb 13, 2023

Description

Summary of changes

This is a fourth preparation step for dynamic memory. Instead of having a one big VM that holds all the arrays, we assign one per array, which enable support for variable length arrays.
We also use a more generic name for the structure which abstract the memory_map as it will be extended for the dynamic array feature.

Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt with default settings.
I have linked this PR to the issue(s) that it resolves.
I have reviewed the changes on GitHub, line by line.
I have ensured all changes are covered in the description.
This PR requires documentation updates when merged.

guipublic added 2 commits

February 13, 2023 17:15


          assign a VM per array

bcb631d


          Merge branch 'master' into gd/dynamic_array4

4668c72

guipublic requested a review from kevaundray

February 13, 2023 17:24


          cargo format

520c2f9

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Outdated Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Outdated Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Outdated Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/operations/cmp.rs Outdated Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen/operations/intrinsics.rs Outdated Show resolved Hide resolved

kevaundray reviewed

View reviewed changes

Contributor

kevaundray left a comment

Changes were pretty straightforward, just left some comments around naming and docs :)

jfecher reviewed

View reviewed changes

crates/noirc_evaluator/src/ssa/acir_gen.rs Outdated Show resolved Hide resolved

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Outdated Show resolved Hide resolved

crates/noirc_evaluator/src/ssa/acir_gen/acir_mem.rs Outdated Show resolved Hide resolved

guipublic added 2 commits

February 14, 2023 09:50


          Code review


          code review

50e7d57

kevaundray approved these changes

View reviewed changes

guipublic added this pull request to the merge queue

Merged via the queue into master with commit 06f058b

guipublic deleted the gd/dynamic_array4 branch

February 14, 2023 12:53

TomAFrench added a commit that referenced this pull request


          Merge branch 'master' into update-clap

a9ad0a5

* master:
  feat(nargo): add flag to verify created proofs (#737)
  chore: Add display for binaryop (#839)
  chore(ssa): per array memory map (#832)
  chore: remove unwanted print of Ok(<path>) in nargo compile (#843)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet