Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(noir_wasm): Update wasm ACIR serialization #898

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Conversation

vezenovm
Copy link
Contributor

Related issue(s)

No issue yet as discovered while quickly iterating development

Resolves #

Description

We switched to using read and write on a Circuit in Noir.

Summary of changes

I switched the noir_wasm to use Circuit::read and and circuit.write instead of Circuit::from_bytes and circuit.to_bytes().

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@vezenovm vezenovm changed the title Fix wasm ACIR serialization fix(noir_wasm): Update wasm ACIR serialization Feb 22, 2023
@vezenovm vezenovm requested review from kobyhallx and phated February 22, 2023 15:34
Copy link
Contributor

@kobyhallx kobyhallx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@kobyhallx kobyhallx enabled auto-merge February 22, 2023 15:39
@vezenovm vezenovm requested a review from jfecher February 22, 2023 16:30
@kobyhallx kobyhallx added this pull request to the merge queue Feb 22, 2023
Merged via the queue into master with commit 575436f Feb 22, 2023
@kobyhallx kobyhallx deleted the mv/acir-ser-wasm branch February 22, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants