fix: evaluate constant division #909
Merged
+18
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Fix constant division by evaluating it at compile time
Test additions / changes
The test that raised the error is too complex to be included as a unit test, although it is most certainly possible to get a simple test with some research, I don't think it matters considering the fix. For the record the constant value was coming from evaluating a condition with predicate.
Checklist
cargo fmt
with default settings.Additional context
The division by 0 panic should become a user error but it should be done when we refactor the acir_gen pass to add error handling.