Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement endianness specified versions of to_bytes to_radix and to_bits #914

Merged
merged 11 commits into from
Mar 1, 2023
Merged

feat: Implement endianness specified versions of to_bytes to_radix and to_bits #914

merged 11 commits into from
Mar 1, 2023

Conversation

Ethan-000
Copy link
Contributor

@Ethan-000 Ethan-000 commented Feb 25, 2023 •
edited
Loading

Related issue(s)

Resolves #913

Description

Summary of changes

Dependency additions / changes

Test additions / changes

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.
  • This PR requires documentation updates when merged.

Additional context

@Ethan-000 Ethan-000 marked this pull request as draft February 25, 2023 15:11
@Ethan-000 Ethan-000 changed the title Implement endianness specified versions of to_bytes to_radix and to_bits feat: Implement endianness specified versions of to_bytes to_radix and to_bits Feb 25, 2023
@Ethan-000
Copy link
Contributor Author

Ethan-000 commented Feb 28, 2023 •
edited
Loading

I'm thinking of removing the integration test as it exposes issues beyond this PR.

It should be added once #915 is fixed

@Ethan-000 Ethan-000 marked this pull request as ready for review February 28, 2023 11:53
guipublic
guipublic approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@guipublic guipublic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's good, thank you.

@guipublic guipublic added this pull request to the merge queue Mar 1, 2023
@Ethan-000
Copy link
Contributor Author

Thanks for the review sir 🙂

Merged via the queue into noir-lang:master with commit 43abc6b Mar 1, 2023
@kevaundray kevaundray mentioned this pull request Mar 1, 2023
Merged
@Ethan-000 Ethan-000 deleted the to_be_radix branch March 1, 2023 11:24
@Savio-Sou Savio-Sou mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench left review comments

@guipublic guipublic guipublic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement endianness specified versions of to_bytes to_radix and to_bits
3 participants
@Ethan-000 @TomAFrench @guipublic