Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: bump noir-bignum to v0.5.0 #40

Merged
merged 8 commits into from
Jan 9, 2025
Merged

feat!: bump noir-bignum to v0.5.0 #40

merged 8 commits into from
Jan 9, 2025

Conversation

kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Jan 8, 2025

Description

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kashbrti
Copy link
Contributor Author

kashbrti commented Jan 8, 2025

I'm having a pretty strange error on this
Screenshot 2025-01-08 at 14 05 51

@kashbrti
Copy link
Contributor Author

kashbrti commented Jan 8, 2025

@TomAFrench any idea what might be causing this?

@TomAFrench
Copy link
Member

Likely differing versions of the bignum crate. Check the nargo.toml

@kashbrti
Copy link
Contributor Author

kashbrti commented Jan 8, 2025

ah there were more than one XD. that solved it thanks

@kashbrti
Copy link
Contributor Author

kashbrti commented Jan 8, 2025

the bignum compiler requirement needs to be dropped for this to be merged

@kashbrti kashbrti changed the title fix: fixing nightly test fails fix: bumped up the bignum version used Jan 9, 2025
@kashbrti kashbrti requested a review from TomAFrench January 9, 2025 13:38
TomAFrench
TomAFrench reviewed Jan 9, 2025
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@TomAFrench TomAFrench changed the title fix: bumped up the bignum version used fix: bumped noir-bignum to v0.5.0 Jan 9, 2025
@TomAFrench TomAFrench changed the title fix: bumped noir-bignum to v0.5.0 feat: bump noir-bignum to v0.5.0 Jan 9, 2025
@TomAFrench TomAFrench changed the title feat: bump noir-bignum to v0.5.0 feat!: bump noir-bignum to v0.5.0 Jan 9, 2025
kashbrti and others added 2 commits January 9, 2025 14:09
@kashbrti @TomAFrench
Update .github/workflows/test.yml
b9c1c67 
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
fixed wrong changes to the workflow
fb3d4fb
@kashbrti
Copy link
Contributor Author

kashbrti commented Jan 9, 2025

There are lots of bug warnings in the example project. will spend some time taking a closer look at them after this is merged.

@TomAFrench
Copy link
Member

That's likely the sha256 issue. It's possible that's a false positive in the unconstrained values SSA check that Ratmir added

@TomAFrench TomAFrench merged commit 068cf97 into main Jan 9, 2025
6 checks passed
@TomAFrench TomAFrench deleted the kb/nightly_test_fails branch January 9, 2025 14:22
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashbrti @TomAFrench