Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cleanup for bb installation #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kobyhallx
Copy link
Contributor

Adds cleanup for acvm-backend-barretenberg when performing new installation.

@TomAFrench
Copy link
Member

I don't think this should be merged in its current form for a couple of reasons:

  • This PR currently nukes the entire backend directory including the CRS so users will have to redownload it from scratch. This unnecessarily slows down the UX as the CRS can be shared between bb versions.
  • The suggested changes to fix: Download expected bb version if installed backend has version mismatch noir#3150 remove the need for this PR when updating to future versions of nargo.
  • It's generally "abstraction leaky", there's no reason for noirup to be aware of backends.

@kobyhallx
Copy link
Contributor Author

kobyhallx commented Oct 16, 2023

I think its generally a good practive to clean particular backend before installing new one. Your current artifacts may be broken or out dated and cleanup would help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants