fix(installers): don't warn when overwriting its own symlink on `inst…

…all` with cache enabled (fixes pdm-project#2502)
noirbizarre · Dec 17, 2023 · ce5a534 · ce5a534
1 parent b6d9d37
commit ce5a534
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/news/2502.bugfix.md b/news/2502.bugfix.md
@@ -0,0 +1 @@
+`pdm install` should not warn when overwriting its own symlink on `install`/`update`.
diff --git a/src/pdm/installers/installers.py b/src/pdm/installers/installers.py
@@ -98,7 +98,8 @@ def _create_links_recursively(
             # A package, create link for the parent dir and don't proceed
             # for child directories
             if os.path.exists(destination_root):
-                warnings.warn(f"Overwriting existing package: {destination_root}", PDMWarning, stacklevel=2)
+                if not os.path.islink(destination_root):
+                    warnings.warn(f"Overwriting existing package: {destination_root}", PDMWarning, stacklevel=2)
                 if os.path.isdir(destination_root) and not os.path.islink(destination_root):
                     shutil.rmtree(destination_root)
                 else: