Move coveralls to the after_success lifecycle hook #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since an external service should not break our builds, this makes sure the builds won’t fail because the exit code of after_success and after_failure stages do not affect the build result.
see: https://docs.travis-ci.com/user/job-lifecycle/#breaking-the-build
We need to also check if switching to codecov (https://codecov.io/) is worth the effort, since we are seeing a lot of issues with coveralls lately.
Signed-off-by: Tanya Tukade tanyatukade.123@gmail.com