Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoiseTorch unconditionally shows "active" when both "filter mic" and "filter headphones" are disabled. #158

Closed
lawl opened this issue Jun 27, 2021 · 4 comments · Fixed by #286

Comments

@lawl
Copy link
Contributor

lawl commented Jun 27, 2021

If nothing is selected to be filtered, we check that indeed no filter is loaded, and since that is true, we show "NoiseTorch loaded", which may confuse users.

@Oman395
Copy link

Oman395 commented Jan 16, 2022

i mean, it's not wrong

@ZyanKLee
Copy link
Contributor

Perhaps the wording could be changed to something like: 'No filter selected' with a neutral color like light blue or gray.
That way the reason for the actual status is more apparent and the text is not misleading, either.

@TheDukeofErl
Copy link
Collaborator

I just put a PR in for this, I noticed it while I was working on different ui changes and it confused me as well, ha.

Perhaps the wording could be changed to something like: 'No filter selected' with a neutral color like light blue or gray.

I opted for "NoiseTorch unconfigured" to be consistent with the other messages.

@melo0187
Copy link

melo0187 commented Jul 8, 2022

Don't know much go, so I'm going out on a limb here... but is ctx.virtualDeviceInUse actually ever initialized?
Just wondering, because I'm experiencing the same issue as reported in #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants