Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't show loaded when both filters are disabled #286

Conversation

TheDukeofErl
Copy link
Collaborator

Fixes #158. When both of the filters are disabled and unloaded, "Noisetorch unconfigured" will be shown in light blue. This should clear up some user confusion in this case.

Using virtualDeviceInUse in addition to noiseSupressorState as
a way to tell if the device is actually in use or not for
setting the status message.
@ZyanKLee
Copy link
Contributor

ZyanKLee commented May 24, 2022

I just looked at this and like the result.
Going one step further I was thinking if we should show something similar, when on one hand at least one filter is being set, but no device being selected?

grafik

well - at least there are no buttons there in that case. so I'm fine with letting it be like that.

@ZyanKLee ZyanKLee merged commit 1231b3c into noisetorch:master May 24, 2022
@TheDukeofErl TheDukeofErl deleted the bugfix/158-filters-disabled-active-fix branch May 24, 2022 12:50
@TheDukeofErl TheDukeofErl restored the bugfix/158-filters-disabled-active-fix branch May 24, 2022 12:50
@TheDukeofErl
Copy link
Collaborator Author

Going one step further I was thinking if we should show something similar, when on one hand at least one filter is being set, but no device being selected?

I do have some code written that will reach that state, as well as a related bugfix I noticed while making it. The bugfix should probably go in no matter what. I can go either way on unconfigured vs loaded when filtering is selected but no device is. Technically I guess it would be more correct to show "unconfigured" but it may be a state in which a user is expecting things to be "active" so a red "inactive" may be more applicable. Either way, I'll get the changes on branches in the afternoon so we can decide what to do.

Hopefully you'll still get the notification from this PR :D

@TheDukeofErl TheDukeofErl deleted the bugfix/158-filters-disabled-active-fix branch May 24, 2022 15:24
@ZyanKLee ZyanKLee added this to the v0.12.0 milestone May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoiseTorch unconditionally shows "active" when both "filter mic" and "filter headphones" are disabled.
2 participants