Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme Restore #304

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Readme Restore #304

merged 5 commits into from
Jun 1, 2022

Conversation

RiemaruKarurosu
Copy link
Contributor

No contrib, only Readme modifications and restore.

#300

  • Style changes (Think it's better center)
    
  • Change links from lawl repo to noisetorch repo
    
  • Lawl added to Special thanks to (Nice to have?)
    

Maybe be nice to have a Multilanguage Readme.

- Style changes
- Change links from lawl repo to noisetorch repo
- Lawl added to Special thanks to
Style changes
    Change links from lawl repo to noisetorch repo
    Lawl added to Special thanks to
@ZyanKLee ZyanKLee requested a review from AXDOOMER May 31, 2022 10:45
@ZyanKLee
Copy link
Contributor

@AXDOOMER when you are done with your final review, can you please have a look at this PR?

Copy link
Contributor

@ZyanKLee ZyanKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some links that still lead to the old project url, please change those

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
RiemaruKarurosu and others added 3 commits May 31, 2022 08:33
Co-authored-by: ZyanKLee <ZyanKLee@users.noreply.github.com>
Co-authored-by: ZyanKLee <ZyanKLee@users.noreply.github.com>
Co-authored-by: ZyanKLee <ZyanKLee@users.noreply.github.com>
@RiemaruKarurosu RiemaruKarurosu requested a review from ZyanKLee May 31, 2022 15:39

# NoiseTorch
[![License: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](https://www.gnu.org/licenses/gpl-3.0) [![Last Release](https://img.shields.io/github/v/release/noisetorch/NoiseTorch?label=latest&style=flat-square)](https://github.com/noisetorch/NoiseTorch/releases)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you center the badges? I think it would look better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I share that sentiment, that centered badges may look good, it is not a necessity to get this PR merged.
Thanks for the changes, @RiemaruKarurosu


# NoiseTorch
[![License: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](https://www.gnu.org/licenses/gpl-3.0) [![Last Release](https://img.shields.io/github/v/release/noisetorch/NoiseTorch?label=latest&style=flat-square)](https://github.com/noisetorch/NoiseTorch/releases)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I share that sentiment, that centered badges may look good, it is not a necessity to get this PR merged.
Thanks for the changes, @RiemaruKarurosu

@ZyanKLee ZyanKLee merged commit df8d60c into noisetorch:master Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants