DANM centralized, API driven IP management extended to work for all CNI compliant backends #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for all backends requesting it. Also MACVLAN plugin recently was enhanced to tolerate the absence of "ipam" key in the CNI config, so "ip":"none" is now enabled for all dynamic backends. The user will be responsible of making sure unsupported IPAM request types are not used for backends not supporting it.
Levovar
force-pushed
the
ipam_for_everyone
branch
from
af15338
to
9ea2f70
Compare
Found a bug: during CNI DEL the IP coming from the DanmEp is in CIDR format, and shall be decoded accordingly. Error found by introducing reserve checks to cnidel UTs too, and also checking how many times DanmNet Update was called. The latter check is introduced to ipam UTs as well, which made me realize we can optimize API write both during Reserve and Free. We only need to push back changes if anything was changed at all. Write need not be called for pur IPv6, and erroneous cases!
Levovar
force-pushed
the
ipam_for_everyone
branch
from
9ea2f70
to
a1e0d0d
Compare
…extended functionality. We actually have more generally supported attributes now, than dynamic-only :)
Levovar
force-pushed
the
ipam_for_everyone
branch
from
fe92dd3
to
fef9008
Compare
Levovar
changed the title
Levovar
added
the
major feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing IPAM code in cnidel so centralized API driven IPAM now works for all backends requesting it!
All includes static.
If cidr/net6 is included in the network manifest, and the Pod's connection request includes "ip" / "ip6"; DANM will call ipam.Reserve and overwrite the "ipam" key in the CNI config of the static delegate with its own fakeipam integration.
This will result in CNI compliant static backends too getting their IPs purely based on a centralized network management API.
Also MACVLAN plugin recently was enhanced to tolerate the absence of "ipam" key in the CNI config. As a result "ip":"none" is now enabled for all backends.
The user will be responsible of making sure unsupported IPAM request types are not used for backends not supporting it; and that only CNI standard compliant backends are fed by DANM's IPAM.