Bump the version of CNI framework used in the DANM code to latest #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DANM, as all CNI depends on "containernetworking" project - both the framework, and the plugins.
Up until now we were using version 6.0 of the framework. From 2017.
It was time for the bump.
The change made to the framework can result in incompatible configs delegated to e.g. to the macvlan CNI, in case the user's CNI binary was compiled with the recent CNI project.
Some API were changed in the last two years so this requires minimal adaptation work, but nothing major.