Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go modules #190

Merged
merged 4 commits into from
Mar 17, 2020
Merged

Migrate to go modules #190

merged 4 commits into from
Mar 17, 2020

Conversation

eMGabriel
Copy link
Collaborator

Change build.sh to speed up build and remove unfixed dependencies
Add hack/tools.go giving dev-tools version fixing via go.mod (e.g. code-generator)
Remove glide
Cleanup gitignore

What type of PR is this?
cleanup

What does this PR give to us:

Which issue(s) this PR fixes (in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@eMGabriel eMGabriel force-pushed the go-mod-migration branch 2 times, most recently from c574fa5 to 9d3862c Compare March 15, 2020 16:17
go.mod Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
scm/build/build.sh Outdated Show resolved Hide resolved
@eMGabriel eMGabriel force-pushed the go-mod-migration branch 7 times, most recently from 1b4f3a8 to 40e2c06 Compare March 17, 2020 00:23
@eMGabriel eMGabriel marked this pull request as ready for review March 17, 2020 00:32
go.mod Show resolved Hide resolved
Change build.sh to speed up build and remove unfixed dependencies
Add hack/tools.go enables k8s.io/code-generator recognised as go.mod dependency
Update k8s.io/kubernetes to v1.14.10
Update k8s.io/{api,apimachinery,client-go,code-generator} to v1.17.3
Remove glide
Cleanup gitignore
doc.go: enable 'go generate' syntactic sugar
run_uts.sh: apply 'go generate', add deepcopy tamper test, cleanup
svcwatcher.go: new code-generator version introduces go context usage
Update and synchronise golang version to 1.13.x for:
- travis ci
- scm dockerfile
- unit test dockerfile
Switch from alpine/golang from source, to golang:1.13-alpine3.10 image
Cleanup
go.mod: go version to 1.13, kubernetes version to 1.17.10
build.sh: remove GO111MODULE definition
run_uts.sh: at first cd into project directory
@eMGabriel
Copy link
Collaborator Author

Rebase on master

@Levovar
Copy link
Collaborator

Levovar commented Mar 17, 2020

CI is now 8.5 minutes faster
noice

@Levovar Levovar merged commit 5f4b79f into nokia:master Mar 17, 2020
@eMGabriel eMGabriel deleted the go-mod-migration branch March 17, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants