-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to go modules #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eMGabriel
force-pushed
the
go-mod-migration
branch
2 times, most recently
from
March 15, 2020 16:17
c574fa5
to
9d3862c
Compare
Levovar
reviewed
Mar 16, 2020
Levovar
reviewed
Mar 16, 2020
Levovar
reviewed
Mar 16, 2020
Levovar
reviewed
Mar 16, 2020
eMGabriel
force-pushed
the
go-mod-migration
branch
7 times, most recently
from
March 17, 2020 00:23
1b4f3a8
to
40e2c06
Compare
eMGabriel
force-pushed
the
go-mod-migration
branch
from
March 17, 2020 13:34
40e2c06
to
bac034c
Compare
Levovar
reviewed
Mar 17, 2020
Change build.sh to speed up build and remove unfixed dependencies Add hack/tools.go enables k8s.io/code-generator recognised as go.mod dependency Update k8s.io/kubernetes to v1.14.10 Update k8s.io/{api,apimachinery,client-go,code-generator} to v1.17.3 Remove glide Cleanup gitignore
doc.go: enable 'go generate' syntactic sugar run_uts.sh: apply 'go generate', add deepcopy tamper test, cleanup svcwatcher.go: new code-generator version introduces go context usage
Update and synchronise golang version to 1.13.x for: - travis ci - scm dockerfile - unit test dockerfile Switch from alpine/golang from source, to golang:1.13-alpine3.10 image Cleanup
go.mod: go version to 1.13, kubernetes version to 1.17.10 build.sh: remove GO111MODULE definition run_uts.sh: at first cd into project directory
eMGabriel
force-pushed
the
go-mod-migration
branch
from
March 17, 2020 15:28
bac034c
to
1331350
Compare
Rebase on master |
CI is now 8.5 minutes faster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change build.sh to speed up build and remove unfixed dependencies
Add hack/tools.go giving dev-tools version fixing via go.mod (e.g. code-generator)
Remove glide
Cleanup gitignore
What type of PR is this?
cleanup
What does this PR give to us:
Which issue(s) this PR fixes (in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: