Enhancing dummy interface capabilities with VLAN and PCI ID information #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the VFIO bound VF is tagged with a VLAN, we create an extra VLAN IF on top of the dummy with the same tag. The VF's PCI ID is added to the dummy (VLAN too) as an Alias. This mapping should be enough for applications to map allocations to the proper device.
|
added possible way of creating dummy interface with the VF's original MAC address also fixed a regression related to SR-IOV handling... well... being totally broken for a time now |
I have absolutely no idea when, but SR-IOV Device Management broke at some point due to not setting DeviceID into DanmEp. This is now fixed, SR-IOV works again as intended. In addition to that MAC address is also saved into DanmEp for VFs, and used to make dummy interfaces.
The dummy NICs will be provisioned with the MAC of the VF, even if they are bound to a user space driver. Also expanded user documentation with the additional feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #175
When the VFIO bound VF is tagged with a VLAN, we create an extra VLAN IF on top of the dummy with the same tag.
The VF's PCI ID is added to the dummy (VLAN too) as an Alias.
This mapping should be enough for applications to map allocations to the proper device.