Adjust webhook timeout & Fix CNI timeout error message #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During CNI ADD/DEL operations DANM waits 30 seconds to finish all the delegated CNI tasks and DanmEp processing. In case the webhook is too slow to respond, DANM timeouts without knowing the reason. The webhook REST call timeout is lowered to 25 seconds (by default it is 30 sec), so its timeout event can arrive back to DANM, which can log that error message.
|
RIP lónyál :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What does this PR give to us:
During CNI ADD/DEL operations DANM waits 30 seconds to finish all
the delegated CNI tasks and DanmEp processing. In case the webhook
is too slow to respond, DANM timeouts without knowing the reason.
The webhook REST call timeout is lowered to 25 seconds (by default
it is 30 sec), so its timeout event can arrive back to DANM, which
can log that error message.
Which issue(s) this PR fixes:
Related to #144, which is still a valid issue.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
No.