Set IPv6 related sysctls, if at least one IPv6 CIDR is set on any interfaces #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
requested changes
Mar 31, 2019
TothFerenc
force-pushed
the
ipv6-sysctl
branch
2 times, most recently
from
87b11fa
to
3b46e30
Compare
|
The code has been refactored heavily. Please review it again, thanks! |
Levovar
reviewed
Apr 4, 2019
Levovar
approved these changes
Apr 4, 2019
|
Looks cool! Except that I just now realized that we prob should have returned from an asynch thread after the first error... all this time :) I guess better late than never |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What does this PR give to us:
DANM takes care of IPv6 related sysctls before CNIs are invoked.
Which issue(s) this PR fixes:
Fixes #68
Special notes for your reviewer:
Tested with ipvlan inside VMs.
Does this PR introduce a user-facing change?:
None.