Replace external arping binary execution with Go implementation #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levovar
reviewed
Apr 18, 2019
TothFerenc
changed the title
|
Tested it on bare metal environment: using ipvlan danmnets right after Pod creation MAC addresses are appeared in the VLAN specific MAC address table on the leaf switches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What does this PR give to us:
fix IPv6 gARP issue, cleaner code
Which issue(s) this PR fixes:
Fixes #75
Special notes for your reviewer:
Now it produces valid gARP packet, but I keep it as WIP until I can test it on a bare metal system where I have access to the switches.
Does this PR introduce a user-facing change?:
NONE