Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the rest of the codebase to consistently use ObjectMeta.Name #81

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

Levovar
Copy link
Collaborator

@Levovar Levovar commented Apr 25, 2019

Continuation of #80
After an impromptu author round-table discussion, it was decided that the whole project shall consistently use ObjectMeta.Name attribute when referring to a DanmNet.

This PR finishes the job.

NetworkID shall control only the following functionality:

  • Influence name of VxLAN host interface
  • Influence name of VLAN host interface
  • Define which CNI config file to be used for a static delegate

@Levovar Levovar force-pushed the networktype_separation branch from bc73454 to 2bc0f83 Compare April 25, 2019 16:00
@Levovar Levovar merged commit b48eb15 into master Apr 25, 2019
@Levovar Levovar deleted the networktype_separation branch April 25, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant