Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: bump actions/stale from 3 to 4.1.0 #1

Closed

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Dec 21, 2021

Bumps actions/stale from 3 to 4.1.0.

Release notes

Sourced from actions/stale's releases.

v4.1.0

Features

v4.0.0

⚠️ This version contains breaking changes ⚠️

Features

Bug Fixes

  • dry-run: forbid mutations in dry-run (#500) (f1017f3), closes #499
  • logs: coloured logs (#465) (5fbbfba)
  • operations: fail fast the current batch to respect the operations limit (#474) (5f6f311), closes #466
  • label comparison: make label comparison case insensitive #517, closes #516
  • filtering comments by actor could have strange behavior: "stale" comments are now detected based on if the message is the stale message not who made the comment(#519), fixes #441, #509, #518

Breaking Changes

  • The options skip-stale-issue-message and skip-stale-pr-message were removed. Instead, setting the options stale-issue-message and stale-pr-message will be enough to let the stale workflow add a comment. If the options are unset, a comment will not be added which was the equivalent of setting skip-stale-issue-message to true.
  • The operations-per-run option will be more effective. After migrating, you could face a failed-fast process workflow if you let the default value (30) or set it to a small number. In that case, you will see a warning at the end of the logs (if enabled) indicating that the workflow was stopped sooner to avoid consuming too much API calls. In most cases, you can just increase this limit to make sure to process everything in a single run.

v3.0.19

  • Enhance logs to provide more detailed output
  • Split certain options to be more granular for Pull Requests vs Issues:
    • any-of-issue-labels
    • any-of-pr-labels
    • remove-issue-stale-when-updated
    • remove-pr-stale-when-updated
  • Dependency updates

v3.0.18

  • Add any-of-labels option
  • Add only-issue-labels, only-pr-labels
  • Clean up, testing and dependency version bumps

v3.0.17

  • Bug fixes, refactoring and milestone exemption

v3.0.16

  • Minor bugfixes and logging improvements

v3.0.15

  • Add milestone exemption
  • Add start date filtering

... (truncated)

Changelog

Sourced from actions/stale's changelog.

4.1.0 (2021-07-14)

Features

4.0.0 (2021-07-14)

Features

Bug Fixes

  • dry-run: forbid mutations in dry-run (#500) (f1017f3), closes #499
  • logs: coloured logs (#465) (5fbbfba)
  • operations: fail fast the current batch to respect the operations limit (#474) (5f6f311), closes #466
  • label comparison: make label comparison case insensitive #517, closes #516
  • filtering comments by actor could have strange behavior: "stale" comments are now detected based on if the message is the stale message not who made the comment(#519), fixes #441, #509, #518

Breaking Changes

  • The options skip-stale-issue-message and skip-stale-pr-message were removed. Instead, setting the options stale-issue-message and stale-pr-message will be enough to let the stale workflow add a comment. If the options are unset, a comment will not be added which was the equivalent of setting skip-stale-issue-message to true.
  • The operations-per-run option will be more effective. After migrating, you could face a failed-fast process workflow if you let the default value (30) or set it to a small number. In that case, you will see a warning at the end of the logs (if enabled) indicating that the workflow was stopped sooner to avoid consuming too much API calls. In most cases, you can just increase this limit to make sure to process everything in a single run.
Commits
  • 7fb802b Bump release to 4.1.0
  • 54197c7 Merge pull request #602 from actions/revert-breaking-change
  • 3a971ae Revert "Merge pull request #586 from C0ZEN/feature/split-pr-and-issue-options"
  • fc4a5ff Merge pull request #595 from actions/dependabot/npm_and_yarn/types/jest-27.0.2
  • db699ab Merge pull request #586 from C0ZEN/feature/split-pr-and-issue-options
  • f8e08de build(deps-dev): bump @​types/jest from 27.0.1 to 27.0.2
  • b83d488 Update dependencies (#592)
  • 1ff6cd7 build(deps): bump tmpl from 1.0.4 to 1.0.5 (#575)
  • 86fed0e build(deps-dev): bump jest-silent-reporter from 0.4.0 to 0.5.0 (#573)
  • 6700440 docs(readme): split the options between common, issues and prs
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 21, 2021
nokute78 pushed a commit that referenced this pull request Jan 8, 2022
output_thread patch #1 : pipe creation is platform dependent, in unixes it's
achieved through the pipe syscall but in windows it's a socket pair created
through libevent which means instead of read/write we need to use recv/send
which was already abstracted through flb_pipe_(r/w).

output_thread patch #2 : in windows the SOCKET data type is defined as an
UINT_PTR which means in 64 bit operating systems it's an 8 byte number
instead of 4. libevent abstracts this through the evutil_socket_t data type
which in turn is abstracted using the flb_pipefd_t data type in fluent bit.

The problem comes to play when calling mk_event_channel_create which
receives 2 int pointers to return both pipe endpoints. This means there
are 2 possible bugs (one of which was happening and the other is not
really a concern I think) :

Since mk_event_channel_create was only modifying the low part of the elements
in the ch_parent_events array and the structure was not zeroed when allocated,
the high parts of those 64 bit members contained garbage which caused any
winsock calls to return error 10038 (not a socket). That's the reason why I
added a memset call in line 421.

There is still a possible issue with mk_event_channel_create which we should
fix by moving our platform dependent data type to mk_lib and defining our
flb local data types to those if need be (for consistency).

Signed-off-by: Leonardo Alminana <leonardo@calyptia.com>
Bumps [actions/stale](https://github.com/actions/stale) from 3 to 4.1.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v3...v4.1.0)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/stale-4.1.0 branch from a3da312 to 468b3d2 Compare January 23, 2022 00:42
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Feb 18, 2022

Looks like actions/stale is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Feb 18, 2022
@dependabot dependabot bot deleted the dependabot/github_actions/actions/stale-4.1.0 branch February 18, 2022 22:37
nokute78 added a commit that referenced this pull request Feb 1, 2023
To fix following race.

==================
WARNING: ThreadSanitizer: data race (pid=15218)
  Read of size 8 at 0x7b2000008398 by thread T1:
    #0 flb_ml_flush_stream_group /home/taka/git/fluent-bit/src/multiline/flb_ml.c:1025 (fluent-bit+0x1930ba)
    #1 flb_ml_flush_parser_instance /home/taka/git/fluent-bit/src/multiline/flb_ml.c:116 (fluent-bit+0x1907ce)
    #2 flb_ml_flush_pending /home/taka/git/fluent-bit/src/multiline/flb_ml.c:136 (fluent-bit+0x1908e4)
    #3 cb_ml_flush_timer /home/taka/git/fluent-bit/src/multiline/flb_ml.c:162 (fluent-bit+0x1909e9)
    #4 flb_sched_event_handler /home/taka/git/fluent-bit/src/flb_scheduler.c:428 (fluent-bit+0x139c4a)
    #5 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:937 (fluent-bit+0x12612e)
    #6 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ccd)

  Previous write of size 8 at 0x7b2000008398 by thread T3:
    #0 calloc ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:672 (libtsan.so.0+0x31edc)
    #1 flb_calloc /home/taka/git/fluent-bit/include/fluent-bit/flb_mem.h:89 (fluent-bit+0x2272f4)
    #2 stream_group_create /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:52 (fluent-bit+0x22c3fb)
    #3 flb_ml_stream_group_get /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:126 (fluent-bit+0x22c799)
    #4 package_content /home/taka/git/fluent-bit/src/multiline/flb_ml.c:229 (fluent-bit+0x190bf6)
    #5 process_append /home/taka/git/fluent-bit/src/multiline/flb_ml.c:499 (fluent-bit+0x191782)
    #6 ml_append_try_parser /home/taka/git/fluent-bit/src/multiline/flb_ml.c:659 (fluent-bit+0x191f1a)
    #7 flb_ml_append /home/taka/git/fluent-bit/src/multiline/flb_ml.c:699 (fluent-bit+0x1920f7)
    #8 process_content /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:456 (fluent-bit+0x342854)
    #9 flb_tail_file_chunk /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:1341 (fluent-bit+0x346ef7)
    #10 in_tail_collect_static /home/taka/git/fluent-bit/plugins/in_tail/tail.c:188 (fluent-bit+0x324ee3)
    #11 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe0369)
    #12 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe10e5)
    #13 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe10e5)
    #14 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x157a02)

  Location is heap block of size 120 at 0x7b2000008380 allocated by thread T3:
    #0 calloc ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:672 (libtsan.so.0+0x31edc)
    #1 flb_calloc /home/taka/git/fluent-bit/include/fluent-bit/flb_mem.h:89 (fluent-bit+0x2272f4)
    #2 stream_group_create /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:52 (fluent-bit+0x22c3fb)
    #3 flb_ml_stream_group_get /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:126 (fluent-bit+0x22c799)
    #4 package_content /home/taka/git/fluent-bit/src/multiline/flb_ml.c:229 (fluent-bit+0x190bf6)
    #5 process_append /home/taka/git/fluent-bit/src/multiline/flb_ml.c:499 (fluent-bit+0x191782)
    #6 ml_append_try_parser /home/taka/git/fluent-bit/src/multiline/flb_ml.c:659 (fluent-bit+0x191f1a)
    #7 flb_ml_append /home/taka/git/fluent-bit/src/multiline/flb_ml.c:699 (fluent-bit+0x1920f7)
    #8 process_content /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:456 (fluent-bit+0x342854)
    #9 flb_tail_file_chunk /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:1341 (fluent-bit+0x346ef7)
    #10 in_tail_collect_static /home/taka/git/fluent-bit/plugins/in_tail/tail.c:188 (fluent-bit+0x324ee3)
    #11 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe0369)
    #12 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe10e5)
    #13 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe10e5)
    #14 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x157a02)

  Thread T1 'flb-pipeline' (tid=15220, running) created by main thread at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xbfb422)
    #2 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1231 (fluent-bit+0x871d1)
    #3 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8732e)

  Thread T3 'flb-in-tail.0-w' (tid=15222, running) created by thread T1 at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xbfb422)
    #2 flb_tp_thread_start /home/taka/git/fluent-bit/src/flb_thread_pool.c:123 (fluent-bit+0x170237)
    #3 flb_input_thread_instance_init /home/taka/git/fluent-bit/src/flb_input_thread.c:543 (fluent-bit+0xe1cca)
    #4 flb_input_instance_init /home/taka/git/fluent-bit/src/flb_input.c:1129 (fluent-bit+0xd73a4)
    #5 flb_input_init_all /home/taka/git/fluent-bit/src/flb_input.c:1216 (fluent-bit+0xd7877)
    #6 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:717 (fluent-bit+0x1252fe)
    #7 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ccd)

SUMMARY: ThreadSanitizer: data race /home/taka/git/fluent-bit/src/multiline/flb_ml.c:1025 in flb_ml_flush_stream_group
==================

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78 added a commit that referenced this pull request Feb 1, 2023
==================
WARNING: ThreadSanitizer: data race (pid=13498)
  Read of size 8 at 0x7b2800010218 by thread T1:
    #0 flb_ml_flush_parser_instance /home/taka/git/fluent-bit/src/multiline/flb_ml.c:115 (fluent-bit+0x19082c)
    #1 flb_ml_flush_pending /home/taka/git/fluent-bit/src/multiline/flb_ml.c:139 (fluent-bit+0x190936)
    #2 cb_ml_flush_timer /home/taka/git/fluent-bit/src/multiline/flb_ml.c:165 (fluent-bit+0x190a3b)
    #3 flb_sched_event_handler /home/taka/git/fluent-bit/src/flb_scheduler.c:428 (fluent-bit+0x139c76)
    #4 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:937 (fluent-bit+0x12615a)
    #5 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

  Previous write of size 8 at 0x7b2800010218 by thread T3:
    [failed to restore the stack]

  Location is heap block of size 160 at 0x7b2800010180 allocated by thread T3:
    #0 calloc ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:672 (libtsan.so.0+0x31edc)
    #1 flb_calloc /home/taka/git/fluent-bit/include/fluent-bit/flb_mem.h:89 (fluent-bit+0x22766f)
    #2 stream_group_create /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:52 (fluent-bit+0x22c776)
    #3 stream_group_init /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:164 (fluent-bit+0x22cd04)
    #4 stream_create /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:203 (fluent-bit+0x22ce88)
    #5 flb_ml_stream_create /home/taka/git/fluent-bit/src/multiline/flb_ml_stream.c:254 (fluent-bit+0x22cfde)
    #6 flb_tail_file_append /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:1002 (fluent-bit+0x34b05e)
    #7 tail_scan_path /home/taka/git/fluent-bit/plugins/in_tail/tail_scan_glob.c:254 (fluent-bit+0x35c3be)
    #8 flb_tail_scan /home/taka/git/fluent-bit/plugins/in_tail/tail_scan.c:41 (fluent-bit+0x35c89c)
    #9 in_tail_init /home/taka/git/fluent-bit/plugins/in_tail/tail.c:364 (fluent-bit+0x32bf7b)
    #10 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:339 (fluent-bit+0xe0d1a)
    #11 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x157a2e)

  Thread T1 'flb-pipeline' (tid=13500, running) created by main thread at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06a20)
    #2 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1231 (fluent-bit+0x871f1)
    #3 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

  Thread T3 'flb-in-tail.0-w' (tid=13502, running) created by thread T1 at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06a20)
    #2 flb_tp_thread_start /home/taka/git/fluent-bit/src/flb_thread_pool.c:123 (fluent-bit+0x170263)
    #3 flb_input_thread_instance_init /home/taka/git/fluent-bit/src/flb_input_thread.c:543 (fluent-bit+0xe1cf6)
    #4 flb_input_instance_init /home/taka/git/fluent-bit/src/flb_input.c:1130 (fluent-bit+0xd73d0)
    #5 flb_input_init_all /home/taka/git/fluent-bit/src/flb_input.c:1217 (fluent-bit+0xd78a3)
    #6 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:717 (fluent-bit+0x12532a)
    #7 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

SUMMARY: ThreadSanitizer: data race /home/taka/git/fluent-bit/src/multiline/flb_ml.c:115 in flb_ml_flush_parser_instance
==================

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78 added a commit that referenced this pull request Feb 2, 2023
To prevent following data race.

==================
WARNING: ThreadSanitizer: data race (pid=4506)
  Read of size 8 at 0x7b9400000010 by thread T1:
    #0 memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 (libtsan.so.0+0x6243e)
    #1 memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:819 (libtsan.so.0+0x6243e)
    #2 lwrb_read /home/taka/git/fluent-bit/lib/lwrb/lwrb/src/lwrb/lwrb.c:199 (fluent-bit+0x8d3d1)
    #3 flb_ring_buffer_read /home/taka/git/fluent-bit/src/flb_ring_buffer.c:197 (fluent-bit+0x176143)
    #4 flb_input_chunk_ring_buffer_collector /home/taka/git/fluent-bit/src/flb_input_chunk.c:1930 (fluent-bit+0x209432)
    #5 flb_sched_event_handler /home/taka/git/fluent-bit/src/flb_scheduler.c:428 (fluent-bit+0x139c76)
    #6 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:937 (fluent-bit+0x12615a)
    #7 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

  Previous write of size 8 at 0x7b9400000010 by thread T3:
    #0 memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:827 (libtsan.so.0+0x6243e)
    #1 memcpy ../../../../src/libsanitizer/sanitizer_common/sanitizer_common_interceptors.inc:819 (libtsan.so.0+0x6243e)
    #2 lwrb_write /home/taka/git/fluent-bit/lib/lwrb/lwrb/src/lwrb/lwrb.c:145 (fluent-bit+0x8d13d)
    #3 flb_ring_buffer_write /home/taka/git/fluent-bit/src/flb_ring_buffer.c:175 (fluent-bit+0x176025)
    #4 append_to_ring_buffer /home/taka/git/fluent-bit/src/flb_input_chunk.c:1904 (fluent-bit+0x20914f)
    #5 flb_input_chunk_append_raw /home/taka/git/fluent-bit/src/flb_input_chunk.c:1966 (fluent-bit+0x20954c)
    #6 input_log_append /home/taka/git/fluent-bit/src/flb_input_log.c:33 (fluent-bit+0x20e8d2)
    #7 flb_input_log_append /home/taka/git/fluent-bit/src/flb_input_log.c:47 (fluent-bit+0x20e955)
    #8 ml_stream_buffer_flush /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:356 (fluent-bit+0x348975)
    #9 process_content /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:575 (fluent-bit+0x3494cf)
    #10 flb_tail_file_chunk /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:1341 (fluent-bit+0x34d428)
    #11 in_tail_collect_event /home/taka/git/fluent-bit/plugins/in_tail/tail.c:328 (fluent-bit+0x32bec0)
    #12 tail_fs_event /home/taka/git/fluent-bit/plugins/in_tail/tail_fs_inotify.c:267 (fluent-bit+0x3329f6)
    #13 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe0395)
    #14 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe1111)
    #15 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe1111)
    #16 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x157a2e)

  Location is heap block of size 8193 at 0x7b9400000000 allocated by main thread:
    #0 calloc ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:672 (libtsan.so.0+0x31edc)
    #1 flb_calloc /home/taka/git/fluent-bit/include/fluent-bit/flb_mem.h:89 (fluent-bit+0x175969)
    #2 flb_ring_buffer_create /home/taka/git/fluent-bit/src/flb_ring_buffer.c:67 (fluent-bit+0x175ab2)
    #3 flb_input_new /home/taka/git/fluent-bit/src/flb_input.c:326 (fluent-bit+0xd3c48)
    #4 service_configure_plugin /home/taka/git/fluent-bit/src/fluent-bit.c:710 (fluent-bit+0x8540d)
    #5 service_configure /home/taka/git/fluent-bit/src/fluent-bit.c:878 (fluent-bit+0x8625f)
    #6 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1182 (fluent-bit+0x87038)
    #7 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

  Thread T1 'flb-pipeline' (tid=4508, running) created by main thread at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06aa0)
    #2 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1231 (fluent-bit+0x871f1)
    #3 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

  Thread T3 'flb-in-tail.0-w' (tid=4510, running) created by thread T1 at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06aa0)
    #2 flb_tp_thread_start /home/taka/git/fluent-bit/src/flb_thread_pool.c:123 (fluent-bit+0x170263)
    #3 flb_input_thread_instance_init /home/taka/git/fluent-bit/src/flb_input_thread.c:543 (fluent-bit+0xe1cf6)
    #4 flb_input_instance_init /home/taka/git/fluent-bit/src/flb_input.c:1130 (fluent-bit+0xd73d0)
    #5 flb_input_init_all /home/taka/git/fluent-bit/src/flb_input.c:1217 (fluent-bit+0xd78a3)
    #6 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:717 (fluent-bit+0x12532a)
    #7 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

SUMMARY: ThreadSanitizer: data race /home/taka/git/fluent-bit/lib/lwrb/lwrb/src/lwrb/lwrb.c:199 in lwrb_read
==================

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78 added a commit that referenced this pull request Feb 2, 2023
To prevent following data race.

==================
WARNING: ThreadSanitizer: data race (pid=31138)
  Read of size 4 at 0x7b1c000002b0 by thread T3 (mutexes: write M12):
    #0 flb_ring_buffer_write /home/taka/git/fluent-bit/src/flb_ring_buffer.c:186 (fluent-bit+0x17608f)
    #1 append_to_ring_buffer /home/taka/git/fluent-bit/src/flb_input_chunk.c:1904 (fluent-bit+0x2091c4)
    #2 flb_input_chunk_append_raw /home/taka/git/fluent-bit/src/flb_input_chunk.c:1966 (fluent-bit+0x2095c1)
    #3 input_log_append /home/taka/git/fluent-bit/src/flb_input_log.c:33 (fluent-bit+0x20e947)
    #4 flb_input_log_append /home/taka/git/fluent-bit/src/flb_input_log.c:47 (fluent-bit+0x20e9ca)
    #5 ml_stream_buffer_flush /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:356 (fluent-bit+0x3489ea)
    #6 process_content /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:575 (fluent-bit+0x349544)
    #7 flb_tail_file_chunk /home/taka/git/fluent-bit/plugins/in_tail/tail_file.c:1341 (fluent-bit+0x34d49d)
    #8 in_tail_collect_static /home/taka/git/fluent-bit/plugins/in_tail/tail.c:188 (fluent-bit+0x32b489)
    #9 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe0395)
    #10 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe1111)
    #11 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe1111)
    #12 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x157a2e)

  Previous write of size 4 at 0x7b1c000002b0 by thread T1:
    #0 flb_input_chunk_ring_buffer_collector /home/taka/git/fluent-bit/src/flb_input_chunk.c:1949 (fluent-bit+0x2094dd)
    #1 flb_sched_event_handler /home/taka/git/fluent-bit/src/flb_scheduler.c:428 (fluent-bit+0x139c76)
    #2 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:937 (fluent-bit+0x12615a)
    #3 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

  Location is heap block of size 104 at 0x7b1c000002a0 allocated by main thread:
    #0 calloc ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:672 (libtsan.so.0+0x31edc)
    #1 flb_calloc /home/taka/git/fluent-bit/include/fluent-bit/flb_mem.h:89 (fluent-bit+0x175969)
    #2 flb_ring_buffer_create /home/taka/git/fluent-bit/src/flb_ring_buffer.c:50 (fluent-bit+0x1759d2)
    #3 flb_input_new /home/taka/git/fluent-bit/src/flb_input.c:326 (fluent-bit+0xd3c48)
    #4 service_configure_plugin /home/taka/git/fluent-bit/src/fluent-bit.c:710 (fluent-bit+0x8540d)
    #5 service_configure /home/taka/git/fluent-bit/src/fluent-bit.c:878 (fluent-bit+0x8625f)
    #6 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1182 (fluent-bit+0x87038)
    #7 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

  Mutex M12 (0x7b1c000002d8) created at:
    #0 pthread_mutex_init ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:1227 (libtsan.so.0+0x4bee1)
    #1 flb_ring_buffer_create /home/taka/git/fluent-bit/src/flb_ring_buffer.c:56 (fluent-bit+0x175a40)
    #2 flb_input_new /home/taka/git/fluent-bit/src/flb_input.c:326 (fluent-bit+0xd3c48)
    #3 service_configure_plugin /home/taka/git/fluent-bit/src/fluent-bit.c:710 (fluent-bit+0x8540d)
    #4 service_configure /home/taka/git/fluent-bit/src/fluent-bit.c:878 (fluent-bit+0x8625f)
    #5 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1182 (fluent-bit+0x87038)
    #6 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

  Thread T3 'flb-in-tail.0-w' (tid=31142, running) created by thread T1 at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06b10)
    #2 flb_tp_thread_start /home/taka/git/fluent-bit/src/flb_thread_pool.c:123 (fluent-bit+0x170263)
    #3 flb_input_thread_instance_init /home/taka/git/fluent-bit/src/flb_input_thread.c:543 (fluent-bit+0xe1cf6)
    #4 flb_input_instance_init /home/taka/git/fluent-bit/src/flb_input.c:1130 (fluent-bit+0xd73d0)
    #5 flb_input_init_all /home/taka/git/fluent-bit/src/flb_input.c:1217 (fluent-bit+0xd78a3)
    #6 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:717 (fluent-bit+0x12532a)
    #7 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa0ced)

  Thread T1 'flb-pipeline' (tid=31140, running) created by main thread at:
    #0 pthread_create ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:969 (libtsan.so.0+0x605b8)
    #1 mk_utils_worker_spawn /home/taka/git/fluent-bit/lib/monkey/mk_core/mk_utils.c:284 (fluent-bit+0xc06b10)
    #2 flb_main /home/taka/git/fluent-bit/src/fluent-bit.c:1231 (fluent-bit+0x871f1)
    #3 main /home/taka/git/fluent-bit/src/fluent-bit.c:1257 (fluent-bit+0x8734e)

SUMMARY: ThreadSanitizer: data race /home/taka/git/fluent-bit/src/flb_ring_buffer.c:186 in flb_ring_buffer_write
==================

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78 added a commit that referenced this pull request Feb 19, 2023
==================
WARNING: ThreadSanitizer: data race (pid=47741)
  Write of size 8 at 0x7b3800010048 by thread T3:
    #0 __mk_list_add /home/taka/git/fluent-bit/lib/monkey/include/monkey/mk_core/mk_list.h:60 (fluent-bit+0x144c66)
    #1 mk_list_add /home/taka/git/fluent-bit/lib/monkey/include/monkey/mk_core/mk_list.h:65 (fluent-bit+0x144cbc)
    #2 flb_downstream_conn_get /home/taka/git/fluent-bit/src/flb_downstream.c:299 (fluent-bit+0x14a6f4)
    #3 in_fw_collect /home/taka/git/fluent-bit/plugins/in_forward/fw.c:130 (fluent-bit+0x49a274)
    #4 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe1395)
    #5 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe2111)
    #6 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe2111)
    #7 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x158b28)

  Previous read of size 8 at 0x7b3800010048 by thread T1:
    #0 flb_downstream_conn_timeouts /home/taka/git/fluent-bit/src/flb_downstream.c:418 (fluent-bit+0x14abd6)
    #1 cb_engine_sched_timer /home/taka/git/fluent-bit/src/flb_engine.c:172 (fluent-bit+0x124a94)
    #2 flb_sched_event_handler /home/taka/git/fluent-bit/src/flb_scheduler.c:428 (fluent-bit+0x13ad70)
    #3 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:945 (fluent-bit+0x127254)
    #4 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa1ced)

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
nokute78 added a commit that referenced this pull request Feb 19, 2023
==================
WARNING: ThreadSanitizer: data race (pid=54513)
  Read of size 8 at 0x7b4400019fe8 by thread T3 (mutexes: write M21):
    #0 mk_list_add /home/taka/git/fluent-bit/lib/monkey/include/monkey/mk_core/mk_list.h:65 (fluent-bit+0x144ca2)
    #1 flb_downstream_conn_get /home/taka/git/fluent-bit/src/flb_downstream.c:302 (fluent-bit+0x14a71d)
    #2 in_fw_collect /home/taka/git/fluent-bit/plugins/in_forward/fw.c:130 (fluent-bit+0x49a2d3)
    #3 input_collector_fd /home/taka/git/fluent-bit/src/flb_input_thread.c:168 (fluent-bit+0xe1395)
    #4 engine_handle_event /home/taka/git/fluent-bit/src/flb_input_thread.c:183 (fluent-bit+0xe2111)
    #5 input_thread /home/taka/git/fluent-bit/src/flb_input_thread.c:384 (fluent-bit+0xe2111)
    #6 step_callback /home/taka/git/fluent-bit/src/flb_worker.c:43 (fluent-bit+0x158b87)

  Previous write of size 8 at 0x7b4400019fe8 by thread T1:
    #0 __mk_list_del /home/taka/git/fluent-bit/lib/monkey/include/monkey/mk_core/mk_list.h:142 (fluent-bit+0x144d08)
    #1 mk_list_del /home/taka/git/fluent-bit/lib/monkey/include/monkey/mk_core/mk_list.h:147 (fluent-bit+0x144d6a)
    #2 prepare_destroy_conn /home/taka/git/fluent-bit/src/flb_downstream.c:209 (fluent-bit+0x14a41a)
    #3 prepare_destroy_conn_safe /home/taka/git/fluent-bit/src/flb_downstream.c:232 (fluent-bit+0x14a4b4)
    #4 flb_downstream_conn_release /home/taka/git/fluent-bit/src/flb_downstream.c:394 (fluent-bit+0x14ab5b)
    #5 fw_conn_del /home/taka/git/fluent-bit/plugins/in_forward/fw_conn.c:179 (fluent-bit+0x4a08c8)
    #6 fw_conn_event /home/taka/git/fluent-bit/plugins/in_forward/fw_conn.c:101 (fluent-bit+0x4a0349)
    #7 flb_engine_start /home/taka/git/fluent-bit/src/flb_engine.c:961 (fluent-bit+0x1273d2)
    #8 flb_lib_worker /home/taka/git/fluent-bit/src/flb_lib.c:629 (fluent-bit+0xa1ced)

Signed-off-by: Takahiro Yamashita <nokute78@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants