Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting props before custom element upgrade doesn't work #190

Closed
nolanlawson opened this issue Jul 17, 2021 · 1 comment · Fixed by #194
Closed

Setting props before custom element upgrade doesn't work #190

nolanlawson opened this issue Jul 17, 2021 · 1 comment · Fixed by #194
Labels
bug Something isn't working

Comments

@nolanlawson
Copy link
Owner 

<emoji-picker></emoji-picker>
<script type="module" src="https://cdn.jsdelivr.net/npm/emoji-picker-element"></script>
<script>document.querySelector('emoji-picker').skinToneEmoji = '👍'</script>

It feels like this should work, but it doesn't because of the timing of the first script loading after the second script. I imagine it's fixable somehow though.
@nolanlawson nolanlawson added the bug Something isn't working label Jul 17, 2021
@0562605543
This comment has been minimized.
nolanlawson added a commit that referenced this issue Jul 26, 2021
@nolanlawson
fix: fix setting props before element upgrade
aae0e72 
fixes #190
@nolanlawson nolanlawson mentioned this issue Jul 26, 2021
Merged
nolanlawson added a commit that referenced this issue Jul 26, 2021
@nolanlawson
fix: fix setting props before element upgrade
a4f08c3 
fixes #190
nolanlawson added a commit that referenced this issue Jul 26, 2021
@nolanlawson
fix: fix setting props before element upgrade (#194)
8e7b5d5 
* fix: fix setting props before element upgrade

fixes #190

* fix: better test and logic

* fix: fix re-setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix setting props before element upgrade nolanlawson/emoji-picker-element
2 participants
@nolanlawson @0562605543