-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to custom favorites emojis #205
Comments
Hmmmm, this is a good point. I had observed this behavior but it hadn't occurred to me that it might be a problem. I think there's a case to be made that "freezing" should just be the default behavior. I can't see a case where you'd want the favorites list to update while the picker is mounted. So maybe the favorites should be frozen throughout the entire picker lifecycle, and only updated in the |
BTW can you describe your use case a bit? I had assumed that most usages are:
... in which case nobody would notice the favorites moving around. I'm curious to know if your use case is different. |
Hi,
There is a behavior which I find odd when using the picker especially when clicking an emoji from the favorites list,
Clicking on an emoji (which is not the first one) may change the favorites list order and when clicking more than once it may be replaced by another emoji and cause confusion,
Illustration:
I think it would be useful to have an option to 'freeze' the favorites list and only change it before/after mounting.
Love your library! 🥇
Thanks,
Yahav
The text was updated successfully, but these errors were encountered: