Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom-elements.json #31

Closed
nolanlawson opened this issue Aug 9, 2020 · 1 comment · Fixed by #142
Closed

Support custom-elements.json #31

nolanlawson opened this issue Aug 9, 2020 · 1 comment · Fixed by #142
Labels
enhancement New feature or request

Comments

@nolanlawson
Copy link
Owner

This is a best practice and doesn't seem super hard to support, although unfortunately web-component-analyzer doesn't seem to really work well for us.

Example custom-elements.json
@nolanlawson nolanlawson added the enhancement New feature or request label Aug 9, 2020
@nolanlawson
Copy link
Owner Author

Played around in VS Code and WebStorm. Only seems to work in VS Code if you add a special config file for each library you're using that has a custom-elements.json file. Can't get it to work for WebStorm, not sure if their "web-types" is compatible. Starting to wonder if supporting this file is really worth the extra maintenance cost.

nolanlawson added a commit that referenced this issue Jun 26, 2021
@nolanlawson
feat: add custom-elements.json
1a64c44 
Fixes #31
nolanlawson added a commit that referenced this issue Jun 26, 2021
@nolanlawson
feat: add custom-elements.json
94eb393 
Fixes #31
@nolanlawson nolanlawson mentioned this issue Jun 26, 2021
Merged
nolanlawson added a commit that referenced this issue Jun 26, 2021
@nolanlawson
feat: add custom-elements.json (#142)
fd3e0f3 
* feat: add custom-elements.json

Fixes #31

* fix: simplify

* fix: add kind: field

* fix: remove type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add custom-elements.json nolanlawson/emoji-picker-element
1 participant
@nolanlawson