Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused code #148

Merged
merged 1 commit into from
Jun 26, 2021
Merged

fix: remove unused code #148

merged 1 commit into from
Jun 26, 2021

Conversation

nolanlawson
Copy link
Owner

Jest 27 was complaining about this code path never getting hit. From looking at the code, it seems indeed impossible for the else to ever get hit - the ready() function always ensures that this._db is set, and we await it. So it will definitely always return true.

Also this should only really matter if someone calls db.close() twice or db.delete() twice... which the tests already cover.

@nolanlawson nolanlawson merged commit 304a18d into master Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant