Add python 3.13 support #1132
Merged
Add python 3.13 support #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meallia
force-pushed
the
py313-logging-lock
branch
from
4876b80
to
8f23670
Compare
Signed-off-by: Jonathan GAYVALLET <jonathan.gayvallet@orange.com>
the logging.Handler class changed in 3.13 and will now always try to acquire the lock in its `handle` method. Removed the optimization that created the handler without a lock when running python >= 3.13. Also configure the CI to run on Python 3.13. Signed-off-by: Jonathan GAYVALLET <jonathan.gayvallet@orange.com>
Meallia
force-pushed
the
py313-logging-lock
branch
from
8f23670
to
f506593
Compare
nolar
approved these changes
Nov 18, 2024
Closed
|
Thank you for your contribution! Sorry for a delayed response from my side. The change is released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
logging.Handlerclass changed in 3.13 and will now always try to acquire the lock in itshandlemethod. (cf python/cpython#109462)Removed the optimization that created the handler without a lock.
Also configure the CI to run on Python 3.13.