Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test peering #519

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Test peering #519

merged 2 commits into from
Aug 27, 2020

Conversation

nolar
Copy link
Owner

@nolar nolar commented Aug 26, 2020

What do these changes do?

Add unit- and functional tests for peering (cross-operator basic synchronization tool to avoid double-processing).

Description

This is the last of the testing topics needed to close #13.

Now, the peering behavior is also tested — same as all other aspects of the framework, and more or less the same way.

In addition, the logging of peering freezes is slightly improved to avoid flooding the freeze-on messages when the state is actually not changed. But keep logging the messages that explain "why" the state is kept "on", even if the reasons change over time.

Issues/PRs

Issues: #13

Type of changes

  • Refactoring (non-breaking change which does not alter the behaviour)
  • Mostly CI/CD automation, contribution experience

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

Otherwise, the on/off messages are logged regularly every 5-10 seconds or so,
despite nothing changes in the freeze mode state.

However, keep the warning on same-priority conflicting operators always logged,
so that the newly appearing operators are noticed in the logs in every moment
in time, not only when the freeze mode is toggled on.
@nolar nolar added the automation CI/CD: testing, linting, releasing automatically label Aug 26, 2020
@kopf-archiver kopf-archiver bot mentioned this pull request Aug 26, 2020
19 tasks
@nolar nolar merged commit 342ee78 into master Aug 27, 2020
@nolar nolar deleted the peering-tests branch August 27, 2020 21:43
@nolar nolar mentioned this pull request Sep 14, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD: testing, linting, releasing automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests automation
1 participant