Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort imports with isort #525

Merged
merged 1 commit into from
Aug 30, 2020
Merged

Sort imports with isort #525

merged 1 commit into from
Aug 30, 2020

Conversation

nolar
Copy link
Owner

@nolar nolar commented Aug 30, 2020

What do these changes do?

Refactoring: sort imports with isort, combine same-source module imports to one statement.

Description

Same-source "from"-imports are compacted into one statement, same as PyCharm tries to auto-format them when refactoring.

This is now done only once manually, but later can become the automated code linting step.

Note that the examples consider kopf as a third-party library — the same as it would be with the real Kopf-based operators.

Issues/PRs

Issues:

Related:

Type of changes

  • Refactoring (non-breaking change which does not alter the behaviour)

Checklist

  • The code addresses only the mentioned problem, and this problem only
  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt

@nolar
Sort imports with isort
752df01 
Same-source "from"-imports are compacted into one statement,
same as PyCharm tries to auto-format them when refactoring.

This is now done only once manually, but later can become the automated
code linting step.

Note that the examples consider `kopf` as a third-party library --
the same as it would be with the real Kopf-based operators.
@nolar nolar added the refactoring Code cleanup without new features added label Aug 30, 2020
@nolar nolar merged commit 4da13b9 into master Aug 30, 2020
@nolar nolar deleted the isort-imports branch August 30, 2020 19:06
@nolar nolar mentioned this pull request Sep 3, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring Code cleanup without new features added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nolar