Unify the logic of annotations for storages: alphabets, lengths, hashes, v1/v2 keys #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purely for the purpose of being more English.
nolar
force-pushed
the
annotations-mixin
branch
from
aadf0d6 to
71b48c0
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Extract the logic of annotations (v1/v2, etc) into a mixin, and use the same logic of suffixing for the diff-base storage too.
This is a preparational PR for #539
Description
Annotations logic and ensuring that it works with K8s API seems to be sophisticated enough to make it reusable, not only available for the progress annotations (handlers' state) but for all annotation storages.
Issues/PRs
Checklist
CONTRIBUTORS.txt