Hide warnings on fake inconsistencies when patching the nonexistent objects #559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress the misleading warnings on inconsistencies when patching the object, which was deleted in/during the handling process.
Description
A snippet to reproduce the case:
Before the fix, it logged the following with the
WARNING
level:After the fix, the logs look like this, with only the
DEBUG
level messages:Inconsistency detection was introduced in #527 — to detect if CRDs are configured to lose the fields (e.g. due to "structural schemas" of K8s 1.16+). That case would be misbehaviour.
The object deletion in the handlers or during the handling process is, to some extent, an expected use-case. Instead of
WARNING
, which implies alerting and reaction, we now log only aDEBUG
level message — to not leave the whole situation hidden (which might be needed for other cases of debugging).Also, remove the frightening "failed" word, and replace it with "skipped" — to show that it was partially expected.