Fix generics & MROs for Python 3.9 and Kopf 0.28 #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No actual need, but just to keep it up to date.
nolar
changed the title
Otherwise, it raises numerous errors in Python 3.9 (and 3.9 only):
```
$ mypy kopf --strict --pretty
kopf/clients/auth.py:18: error: syntax error in type comment
vault_var: ContextVar[credentials.Vault] = ContextVar('vault_var')
^
kopf/clients/auth.py:108: error: syntax error in type comment
default_namespace: Optional[str]
^
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Enable Kopf for Python 3.9 by fixing an issue when some of the classes were reporting
TypeError: Cannot create a consistent method resolution order (MRO) for bases Generic, ...on their declaration (not at runtime).Since nothing changes essentially in the codebase, I assume the change is safe enough. That was surprisingly easy (easier than I thought it will be).
Related: k8spin/k8spin-operator#24
The proper Python tag (3.9 instead of 3.9-dev) will be released later — it needs Travis & pyenv to support 3.9 first, but 3.9 was released only 2 days ago. See: https://travis-ci.community/t/python-3-9-0-build/10091