-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give quotes for inbound channels and email #11
base: master
Are you sure you want to change the base?
Conversation
Running this in prod already since the nolooking PR is more important |
fc2ddf4
to
2a8616c
Compare
please consider using POST as changed in this commit DanGould@362fdde. That commit is now running in prod |
Shouldn't this only send a notification when someone pays us? Otherwise we have to watch the payment address |
3d16959
to
3fe03c5
Compare
let price = 30_000; | ||
let resp_capacity = 1_000_000; //sats | ||
let resp_duration = 1; //month | ||
let payment_address = crate::lnd::get_onchain_address().await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a bit hacky to have gotten the software this far and still call what look like static functions when they that rely on a specific config. Still good on you for making it work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fine, the config is loaded within each function. nicer than keeping config around
TODO: Bubble up results within that separate thread and just ignore them. We can't afford to panic! |
I think this is what we're running. If so, it gets my approval and should be merged asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gg
Adds an endpoint
Resposnds with an address.
Currently hardcoded to
Sends us an email notification/invoice using aws ses via
(need
~/.aws/credentials
)