schedule: fix the metrics flush

Signed-off-by: nolouch <nolouch@gmail.com>
nolouch · Apr 18, 2024 · aa54429 · aa54429
1 parent 0214778
commit aa54429
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/schedule/schedulers/balance_leader.go b/pkg/schedule/schedulers/balance_leader.go
@@ -354,6 +354,7 @@ func (l *balanceLeaderScheduler) Schedule(cluster sche.SchedulerCluster, dryRun
  if dryRun {
  collector = plan.NewCollector(basePlan)
  }
+ defer l.filterCounter.Flush()
  batch := l.conf.getBatch()
  balanceLeaderScheduleCounter.Inc()
 
@@ -395,7 +396,6 @@ func (l *balanceLeaderScheduler) Schedule(cluster sche.SchedulerCluster, dryRun
  }
  }
  }
- l.filterCounter.Flush()
  l.retryQuota.GC(append(sourceCandidate.stores, targetCandidate.stores...))
  return result, collector.GetPlans()
 }

diff --git a/pkg/schedule/schedulers/balance_region.go b/pkg/schedule/schedulers/balance_region.go
@@ -114,6 +114,7 @@ func (s *balanceRegionScheduler) IsScheduleAllowed(cluster sche.SchedulerCluster
 
 func (s *balanceRegionScheduler) Schedule(cluster sche.SchedulerCluster, dryRun bool) ([]*operator.Operator, []plan.Plan) {
  basePlan := plan.NewBalanceSchedulerPlan()
+ defer s.filterCounter.Flush()
  var collector *plan.Collector
  if dryRun {
  collector = plan.NewCollector(basePlan)
@@ -217,7 +218,6 @@ func (s *balanceRegionScheduler) Schedule(cluster sche.SchedulerCluster, dryRun
  }
  s.retryQuota.Attenuate(solver.Source)
  }
- s.filterCounter.Flush()
  s.retryQuota.GC(stores)
  return nil, collector.GetPlans()
 }