Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAMMPS parsing failure #52

Closed
fxcoudert opened this issue Jul 16, 2023 · 6 comments · Fixed by #86
Closed

LAMMPS parsing failure #52

fxcoudert opened this issue Jul 16, 2023 · 6 comments · Fixed by #86

Comments

@fxcoudert
Copy link

Data: https://nomad-lab.eu/prod/v1/gui/user/uploads/upload/id/3r7neW3GSU63WbJGYfZhuw
Failed to parse 2 output files, and did not recognise the trajectory.

@Pepe-Marquez
Copy link

Hey @JFRudzinski, can you have a look at this?
Would reprocessing in staging work?
Some screenshots in this Twitter thread just in case it provides more info: https://twitter.com/fxcoudert/status/1680665798703030272?s=20

@JFRudzinski
Copy link
Collaborator

JFRudzinski commented Jan 4, 2024

@fxcoudert I am sorry for the VERY long delay in getting to this issue!!

I am trying to dedicate some time now to improving the Lammps parser. If you wouldn't mind sharing your data that failed to parse with me, it would be very helpful. If the above-mentioned upload exist, you can give me access by adding me as a reviewer via the "manage upload members" button (icon looks like 2 people
Screenshot from 2024-01-04 10-29-30
) on the upload page in NOMAD.

@fxcoudert
Copy link
Author

You are now added as reviewer for this upload:

Capture d’écran 2024-01-04 à 15 42 27

@JFRudzinski
Copy link
Collaborator

@fxcoudert excellent, thank you very much!

@JFRudzinski
Copy link
Collaborator

This issue appears to be linked to #37 , will confirm after solving that one

@JFRudzinski JFRudzinski linked a pull request Jan 19, 2024 that will close this issue
@JFRudzinski
Copy link
Collaborator

Update: The major processing issues here have now been solved. This had to do with:

  1. Not recognizing the data file
  2. Nan calculated for mass fraction for systems without recognized atoms

Once these changes go through, the system and method data will be properly parsed. However, overall workflow within this example is not recognized (i.e., multiple MD runs). This corresponds to a bigger extension of Lammps support needed. I have opened an issue for this #89 if anyone would like to follow the progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants