-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
52 lammps parsing failure #86
Conversation
@ladinesa please take a look at what I did here to improve the search for the Lammps data file. I know that the parser matching code has functionality to check the headers, but I wasn't sure if it was easy/possible to extract that for alternative use, so I just wrote my own function. |
atomisticparsers/lammps/parser.py
Outdated
)[ | ||
1 | ||
] # JFR- @Alvin Please check this - changed from [0] to [1] for case that filename is leading with log | ||
prefix = os.path.basename(self.mainfile).rsplit(".", 1)[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we need error handling here in case basename does not contain .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check again.
@ladinesa Can I merge this? |
affirmative |
No description provided.