-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency links to git branches #34
Conversation
So, I fixed one thing with the dependencies that else breaks the distro dev |
Looks fine by me, but Alvin should probably make the call here |
I just removed an older fashion of loading the submodules. Anyhow, I'm fine waiting, as long as we don't run into issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems fine to me, but maybe let's just wait for Alvin to 100% confirm since I think it's not urgent
yes pls remove the git dep. about the second change, it is ok if this works. i have to put this since i have old imports like from simulationworkflowschema import MolecularDynamics which do not anymore work. so if this is fixed already then pls remove the hack |
I finally was able to test this. It appears to me that this change actually causes an issue: ImportError while loading conftest '/home/jfrudzinski/work/soft/nomad-distro-dev/packages/nomad-schema-plugin-simulation-workflow/tests/conftest.py'.
tests/conftest.py:26: in <module>
from nomad.normalizing import normalizers
../nomad-FAIR/nomad/normalizing/__init__.py:128: in <module>
NormalizerInterfaceNew(entry_point.load(), entry_point.level)
../../.venv/lib/python3.12/site-packages/simulationworkflownormalizer/__init__.py:24: in load
from .normalizer import SimulationWorkflowNormalizer
../../.venv/lib/python3.12/site-packages/simulationworkflownormalizer/normalizer.py:21: in <module>
from simulationworkflowschema import (
E ImportError: cannot import name 'SinglePoint' from 'simulationworkflowschema' (/home/jfrudzinski/work/soft/nomad-distro-dev/packages/nomad-schema-plugin-simulation-workflow/simulationworkflowschema/__init__.py) When testing with the current develop branch, all my tests pass. |
covered by #40 but replaced the import hack to avoid errors for now |
No description provided.