Miguel/ava 363 proposals on nomad bridge security #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage to use BoundedVec
luketchang
force-pushed
the
luke/nomad-dev-pallets
branch
2 times, most recently
from
5a39730 to
f37e290
Compare
…yz/avail into luke/nomad-dev-pallets
…n-nomad-bridge-security
luketchang
reviewed
Sep 29, 2022
- New Benchmarks for `nomad/da-bridge` - Add header hash to `try_dispatch_data_root`. - Add assertions to `verify` section in benchmarks.
|
Also if you could update the subxt scripts to use the new metadata, that'd be great. Each time signature of method changes, we need to update this |
luketchang
reviewed
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security
do_dispatchhas been re-written to avoid modification on storage and failure, as it is not transactional.do_updateneeds to betransactionalto avoid inconsistency between storages if the internal loop fails.updateuses amax_index_witnessto calculate the proper weight.Benchmarks
nomad-home::updateis whenTreehasTREE_DEPTH (=32)as depth. We useinit_treefn to generate that case on theupdatebenchmark.Updatercontains NON compatible WASM code, we use pre-images on benchmarks:fn expected_signed_update()andfn expected_longest_tree_signed_update(). There are UTs to ensure their values are correct.Other changes
da-bridge::try_dispatch_data_rootuses the block number & the data root instead the whole header.Homecrate has been renamed toNomad-Home.