Improve Typing for Aesthetics and Transforms #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into don/refactor/aesthetic-types
bmschmidt
approved these changes
Aug 24, 2022
| @@ -126,7 +126,7 @@ export class ReglRenderer extends Renderer { | |||
| const { prefs } = this; | |||
| const { transform } = this.zoom; | |||
| const { aes_to_buffer_num, buffer_num_to_variable, variable_to_buffer_num } = this.allocate_aesthetic_buffers(); | |||
| console.log(prefs.arrow_table); | |||
| // console.log(prefs.arrow_table); | |||
There was a problem hiding this comment.
Feel free to just kill anything that isn't a console.warn or console.error. I would lint them out of existence except there are few cases that they're actually intentional, alas.
Comment on lines
-30
to
+36
| const scales : { [key : string] : Function } = { | ||
| const scales: Record< | ||
| Transform, | ||
| (range?: Iterable<number>) => ScaleContinuousNumeric<number, number, never> | ScaleIdentity<never> | ||
| > = { |
There was a problem hiding this comment.
This is nice, glad to see this signature clarified.
Comment on lines
+692
to
+696
| type ConcreteAesthetic = | ||
| | X | ||
| | Y | ||
| | Size | ||
| | Jitter_speed |
There was a problem hiding this comment.
What's up with this formatting, especially the line before the first X? I'm conditioned to think of leading lines as guard rather than an OR.
There was a problem hiding this comment.
It's the same formatting that OCaml uses - I prefer it for multi-line union types as it keeps everything consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransformtypeAesthetic.tstotypes.tsand export itTransformtype in channel type definitionsdimmethod strongly typedstoreandscalesstrongly typed