Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop generation button no longer works in v3.6.0 #3333

Closed
manyoso opened this issue Dec 20, 2024 · 0 comments
Closed

Stop generation button no longer works in v3.6.0 #3333

manyoso opened this issue Dec 20, 2024 · 0 comments
Assignees
@manyoso
Labels
chat gpt4all-chat issues

Comments

@manyoso
Copy link
Collaborator

manyoso commented Dec 20, 2024

Seems we have a regression with the stop generation button in v3.6.0. The ChatModel::get(...) function was removed which was used in a few different places in QML. This wasn't noticed because we don't get a compiler notice unfortunately and it was removed as part of a last minute bug fix.

Working on fixing...
@manyoso manyoso added bug-unconfirmed chat gpt4all-chat issues labels Dec 20, 2024
@manyoso manyoso self-assigned this Dec 20, 2024
@manyoso manyoso changed the title Stop generation button (and parts of datalake) no longer works in v3.6.0 Stop generation button no longer works in v3.6.0 Dec 20, 2024
This was referenced Dec 20, 2024
Open
Closed
manyoso added a commit that referenced this issue Dec 20, 2024
@manyoso
The ChatModel::get method was removed which unfortunately caused a re…
45c53ee 
…gression

in a few places in QML that were using this method. This PR fixes two of
these issues:

* Issue #3333 - the stop generation button no longer working
* Issue #3335 - the copy entire conversation button no longer working

It also adds a fixme in the code for a third issue which is less of a priority:

* Issue #3334 - not sending the conversation to the datalake.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso manyoso mentioned this issue Dec 20, 2024
Merged
@manyoso manyoso closed this as completed Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manyoso manyoso

Labels
chat gpt4all-chat issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manyoso