Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Brave search tool #2737

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

WIP Brave search tool #2737

wants to merge 30 commits into from

Conversation

manyoso
Copy link
Collaborator

@manyoso manyoso commented Jul 25, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

@manyoso manyoso marked this pull request as draft July 25, 2024 19:47
@manyoso manyoso force-pushed the brave_search_tool branch 2 times, most recently from 3c57db8 to cfb08a6 Compare July 28, 2024 15:50
@manyoso manyoso changed the title Brave search tool WIP Brave search tool Jul 31, 2024
@cebtenzzre cebtenzzre mentioned this pull request Aug 5, 2024
Closed
@cebtenzzre cebtenzzre linked an issue Aug 5, 2024 that may be closed by this pull request
Connect the models to the internet #1344
Open
@manyoso manyoso force-pushed the brave_search_tool branch 3 times, most recently from b10d96f to 393fe5c Compare August 13, 2024 01:49
@manyoso
Brave search tool calling.
f4fb3df 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Change the name to announce the beta.
a71db10 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Fix problem with only displaying one source for tool call excerpts.
1c9911a 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Add the extra snippets to the source excerpts.
c78c95a 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Fix the way we're injecting the context back into the model for web s…
dda59a9 
…earch.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Change the suggestion mode to turn on for tool calls by default.
d2ee235 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Change the name to inc the beta.
b0578e2 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Inc again for new beta.
b9684ff 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Stop hardcoding the tool call checking and rely upon the format advoc…
7c7558e 
…ated by ollama for tool calling.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Refactor to handle errors in tool calling better and add source comme…
fffd9f3 
…nts.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Refactor the brave search and introduce an abstraction for tool calls.
dfe3e95 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Begin converting the localdocs to a tool.
01f67c7 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Serialize the source excerpts from and to pure json
27b86da 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Use parameters which is in keeping with other standard practices.
5fc2ff8 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Implement error handling for tool calls.
244b826 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Tool model.
cedba6c 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Move the usearch submodule to third_party dir.
f93b764 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Add jinja third party dependency.
00ecbb7 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Refactor and make use of jinja templates.
c3cfaff 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Get rid of the name change now that 3.2.0 has been released.
587dd55 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Use an enum for tool usage mode.
227dbfd 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Move the jinja processing to mysettings and validation.
48117cd 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Move to a brave search specific settings page.
a673087 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Don't advertise brave.
f118720 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Handle the forced usage of tool calls outside of the recursive prompt…
75dbf9d 
… method.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Abstract the built-in web search completely away from ChatLLM.
991afc6 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Breakout the ask before running which can be thought of as a security…
4cb9569 
… feature.

Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Display the antenna by introducing notion of privacy scopes to tools.
054ca43 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Implement all the settings for the web search.
3a56468 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
@manyoso
Force tool usage and refactor.
4ae6acd 
Signed-off-by: Adam Treat <treat.adam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect the models to the internet
1 participant
@manyoso